Implement access to device and dtype
#65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #23
This PR exposes
deviceanddtypesuch that they can be controlled and set externally by the user. This is particularly relevant for runningdiffwofoston GPU by settingdevice="cuda". There are example of this in the notebooks and in the documentation.The tests have been update by adding a new
@pytest.fixturethat checks if a GPU is available, and if so, it re-runs the most important tests on the GPU a second time. Notice that GitHub actions do not provide GPU access (for free), so I have been using my local hardware to test the code.Notice that without finalizing the Engine, the GPU device could be slower than the CPU, due to temporary fixes like the use of
deepcopyin theTestEngine.