Add a optimization notebook for phenology #67
Conversation
|
SarahAlidoost
requested review from
SCiarella,
michielkallenberg and
ronvree
|
@ronvree and @michielkallenberg In this pull request, I added a notebook showing optimization of phenology model. It has an early stop too. When you have time, please have a look. If you want to run the notebook, please install the package in this branch. The links in the documentation will be updated automatically after merge. @SCiarella In addition to the notebook, I changed a test in this PR. I will update the other notebook in #66 |
There was a problem hiding this comment.
Great work @SarahAlidoost!
The nb looks flawless to me, if the others confirm, let's merge this 🚀
ronvree
left a comment
ronvree
left a comment
There was a problem hiding this comment.
I ran the notebook but was a bit confused about one thing. Maybe I made a mistake or something isn't clear to me, but I hope you can shed some light on this. The notebook's output looks good but I was a bit confused why there seems to be no changes in the TBASEM parameter. When looking at DVS_Phenology I figured this would mean the crop is not in an emerging stage? What confused me more is that when I tried to test this by modifying the DVS_Phenology class it did not affect the simulations, even after (re-)installing from the local branch and re-running all notebook cells. Does the TestEngineHelper load DVS_Phenology properly?
closes #61
closes #52