-
Notifications
You must be signed in to change notification settings - Fork 0
Split leaf and root dynamics optimization notebooks #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@michielkallenberg @ronvree @SCiarella @fnattino in this pull request, STE method is used for the sigmoid approximation for the parameter |
|
SCiarella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SarahAlidoost, I really prefer this new approach to the sigmoid because the gradient now is much more controlled.
Later, we could even allow the user to set a lower sharpness to have a better gradient for parameter optimization, but right now the value of 1000 that you have chosen looks ok.
I approve this PR for merge 👍
|
I also think this is a really good idea! During the development it's much better to remove the ambiguity of whether some sigmoid approximates the original model well enough. Great suggestion! Although the soft threshold might in some case have a more realistic biophysical interpretation (as also mentioned by Francesco in issue #68), I feel these discussions should be separated from the initial model development. If I understand correctly the sharpness should ideally still be set based on the magnitude of the input if we want to guarantee there are no issues during optimization? Would it make sense to implement the thresholds as nn.Module instances so it's easier to inspect their behavior and see the impact of any potential adjustments? Thanks @SarahAlidoost! I also approve the PR for merge |



closes #66
closes #68
🔴 After merging #61, I will update the docs.