Create witx-type-representation.md#318
Conversation
3ca198e to
19a57f7
Compare
sunfishcode
left a comment
There was a problem hiding this comment.
Cool! This looks like a great start documenting a part of witx which is currently undocumented!
Could you add a link to this from here? https://github.com/WebAssembly/WASI/blob/master/docs/witx.md
One other thing which may be useful to mention in the intro; the representations of these types are exposed when used with linear memory, however witx is also meant to be used in the future in non-linear-memory contexts as well, in which case the representation is opaque.
|
my bad on taking forever lol |
| iovec | ||
|
|
||
| buf: Pointer<u8> @ offset 0 | ||
| buf_len: size @ offset 4 |
There was a problem hiding this comment.
The offset may be 4 or 8 depends on sizeof pointer
There was a problem hiding this comment.
It seems that the docs don't mention this distinction - I'm unsure if it's within scope of this PR to mention it if the docs don't.
ae8b5ac to
0c4b9ec
Compare
0c4b9ec to
ca38d96
Compare
|
Apologies for it having been a while since I've worked on this. I tried to update the terminology to be more in-line with what's currently in use, but I might've glossed something over. |
|
It's been five years and there have been quite a few changes to the repo and WIT/WASI/the ecosystem at large in the meantime -- @monoclex hopefully you don't mind but I'm closing this draft as it probably is unlikely to get finished and merged anytime soon (just using the past as a guide) Happy to re-open if it's still relevant/you find time though! |
This document summarizes the types that can be found in the phaser snapshots. The goal of this is that it should be a one-stop shop for people looking to implement ABI compatibility with certain types. This PR was created to resolve one of the issues brought up with #316
Points of improvement before merging:
subscription_uwould be hard to read on mobile