Update documentation for wasi:filesystem:descriptor#link-at.#848
Open
wingo wants to merge 2 commits intoWebAssembly:mainfrom
Open
Update documentation for wasi:filesystem:descriptor#link-at.#848wingo wants to merge 2 commits intoWebAssembly:mainfrom
wasi:filesystem:descriptor#link-at.#848wingo wants to merge 2 commits intoWebAssembly:mainfrom
Conversation
It would have been nice for `linkat` to do just what POSIX does, but Windows includes the case of hard-linking a directory in EACCESS instead of the POSIX-prescribed EPERM.
This was referenced Dec 9, 2025
| /// Fails with `error-code::no-entry` if the old path does not exist, | ||
| /// with `error-code::exist` if the new path already exists, and | ||
| /// `error-code::not-permitted` if the old path is not a file. | ||
| /// Behavior is as described by [POSIX |
Contributor
There was a problem hiding this comment.
Would you mind keeping the previous description of failure modes, and adding this prose + link at the bottom with something like "for more information, see " ?
Laying out the common failure mode and meanings is reasonable in the docs, rather than (for the same reason we note the failure mode for hard links).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would have been nice for
linkatto do just what POSIX does, but Windows includes the case of hard-linking a directory in EACCESS instead of the POSIX-prescribed EPERM.