Remove double async'ness from read-directory.#869
Merged
Conversation
Member
|
Makes sense to me, based on the general rule we discussed in #870. |
alexcrichton
approved these changes
Feb 4, 2026
ricochet
force-pushed
the
remove-async-from-read-directory
branch
from
cf59c88 to
c617cfd
Compare
ricochet
approved these changes
Feb 5, 2026
The method also returns a `future` so all concurrency can be encapsulated through that.
ricochet
force-pushed
the
remove-async-from-read-directory
branch
from
c617cfd to
0b96e19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method also returns a
futureso all concurrency can be encapsulated through that.