Update C and JS libraries with relaxed atomics support #8248
+530
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenfontanella
force-pushed
the
relaxed-atomics-api
branch
4 times, most recently
from
ef937a5 to
b08108e
Compare
stevenfontanella
force-pushed
the
relaxed-atomics-api
branch
from
b08108e to
a83a8a4
Compare
stevenfontanella
changed the title
kripken
reviewed
Jan 30, 2026
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Please update the changelog with the breaking changes.
| Module['MemoryOrder'] = {}; | ||
| [ 'Unordered', | ||
| 'SeqCst', | ||
| 'AcqRel' |
Member
There was a problem hiding this comment.
I think lowercase is more consistent for the values: we try to match the wasm text format where possible.
Member
There was a problem hiding this comment.
Maybe the new github UI is confusing me, but this seems to be marked resolved although the values are still uppercase? SeqCst instead of seqcst as in the text format etc.
Member
There was a problem hiding this comment.
Oh, I see, they are converted below... got it.
tlively
approved these changes
Jan 30, 2026
Member
Author
|
Forgot a couple things, will send another update. |
kripken
reviewed
Jan 30, 2026
| Current Trunk | ||
| ------------- | ||
| - The c api now has separate functions for `CallRef` and `ReturnCallRef` matching the semantics of `Call` and `ReturnCall`. | ||
| - The C api now has separate functions for `CallRef` and `ReturnCallRef` matching the semantics of `Call` and `ReturnCall`. |
Member
There was a problem hiding this comment.
Please add PR numbers to each line here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoryOrderargument for BinaryenAtomicLoad, BinaryenAtomicStore, BinaryenAtomicRMW, and BinaryenAtomicCmpxchg.Part of #8165