Skip to content

Shared string builtins #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tlively wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Shared string builtins #108

tlively wants to merge 3 commits into from

Conversation

@tlively
Copy link
Member

@tlively tlively commented Jan 16, 2026

Describe overloading the existing string builtins to be importable with shared versions of the existing signatures.

@tlively
Shared string builtins
4b73a6d 
Describe overloading the existing string builtins to be importable with shared versions of the existing signatures.
@tlively tlively requested a review from conrad-watt January 16, 2026 01:02
@tlively
Copy link
Member Author

tlively commented Jan 16, 2026

cc @manoskouk, @jakobkummerow, @Liedtke

Liedtke
Liedtke approved these changes Jan 16, 2026
View reviewed changes
Copy link

@Liedtke Liedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

jakobkummerow
jakobkummerow approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@jakobkummerow jakobkummerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit.

@jakobkummerow
Copy link
Contributor

jakobkummerow commented Jan 16, 2026

What about magic string constants in imported globals? Do we need importedSharedStringConstants: "some_namespace"? Or should the existing mechanism be generalized similarly to the functions, i.e. (global $helloworld (import "'" "hello, world!") (shared externref)) will be populated with a shared string because of its type?

tlively and others added 2 commits January 16, 2026 10:59
@tlively @jakobkummerow
Apply suggestion from @jakobkummerow
7f4a48c 
Co-authored-by: jakobkummerow <jkummerow@chromium.org>
@tlively
Add paragraph about imported strings
50f6497
@tlively
Copy link
Member Author

tlively commented Jan 16, 2026

@jakobkummerow, good point. I added a paragraph now about imported strings. There's no need for a separate namespace for shared strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@conrad-watt conrad-watt Awaiting requested review from conrad-watt

2 more reviewers

@Liedtke Liedtke Liedtke approved these changes

@jakobkummerow jakobkummerow jakobkummerow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tlively @jakobkummerow @Liedtke