[spectec] Clean up IL semantics and elaborator (WIP) #2056
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up and tightens SpecTec IL scoping and validation and revamps the frontend elaborator accordingly.
The relevant tweaks to the IL are as follows (see also the diff on il/ast.ml):
(x1:t1,...,xN:tN)now bind just variables, not expressions. Furthermore, these variables are properly locally scoped. That implies that they no longer show up in outer binder lists. They scope over field types to the right as expected.syntax t = C(a : t, b : u(a)) -- if $p(a, b), the variablesaandbscope over the premise.syntax t = C(a : t, b : u(a)) {c : v(b)} -- if $f(a, b) = c.iandjine^(i<n){j <- k}are now properly locally scoped (this was a bit ambiguous before). That implies that they also no longer show up in outer binder lists.The net effect of these changes is that all scoping now is much more standard and there no longer is any duplication between "binders" and parameters. As a concrete example, this e.g. is how the elaboration of the type
namesimplifies:There are only very few cases left where quantifiers on variants actually still show up (for example, the
SUBNORMconstructor for floats). Note that quantifiers remain heavily used for function definitions and their argument patterns.Currently there still is a test failure on the AL interpreter.