Unit tests #82

arnabcs17b006 · 2020-06-22T12:00:04Z

Do not merge until previous ones are merged!

arnabcs17b006 · 2020-06-22T12:00:47Z

Do not merge until previous ones have been merged!

Cargo.toml

c_examples/mem-dump.c

src/driver/kvm.rs

Wenzel · 2020-08-19T23:07:16Z

@arnabcs17b006 same question here ?

arnabcs17b006 · 2020-08-19T23:08:36Z

Yes.. It is relevant

…

On Thu, Aug 20, 2020, 04:37 Mathieu Tarral ***@***.***> wrote: @arnabcs17b006 <https://github.com/arnabcs17b006> same question here ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#82 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALGMDC5ZGNQLMANLOT3RMNLSBRLLFANCNFSM4OEQPDLQ> .

Wenzel · 2020-08-19T23:15:40Z

Then I think you need a rebase too

Cargo.toml

rageagainsthepc · 2020-08-21T10:37:36Z

You should not change anything in the existing tests. They are fine as there are right now. Even worse, your changes to them are causing runtime errors.

rageagainsthepc · 2020-08-21T10:38:56Z

Looks like you have not addressed any comments from my previous review.

codecov-commenter · 2020-08-21T12:13:45Z

Codecov Report

Merging #82 into master will increase coverage by 52.35%.
The diff coverage is 91.58%.

@@             Coverage Diff             @@
##           master      #82       +/-   ##
===========================================
+ Coverage   16.73%   69.09%   +52.35%     
===========================================
  Files           5        5               
  Lines         472      990      +518     
  Branches       65      104       +39     
===========================================
+ Hits           79      684      +605     
+ Misses        382      219      -163     
- Partials       11       87       +76

Flag	Coverage Δ
#unittests	`69.09% <91.58%> (+52.35%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/api.rs	`1.06% <0.00%> (+1.06%)`	⬆️
src/driver/kvm.rs	`84.42% <92.45%> (+57.27%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0d5537...51d3d67. Read the comment docs.

src/driver/kvm.rs

rageagainsthepc · 2020-08-25T15:23:41Z

src/driver/kvm.rs

+            )
+            .times(1)
+            .returning(|_, _, _| Ok(()));
+        kvmi_mock


@Wenzel is it logically possible for toggling pagefault interception on to fail if called a second time?

src/driver/kvm.rs

arnabcs17b006 force-pushed the unit_tests branch 4 times, most recently from dae0ece to d08437a Compare July 2, 2020 22:44

rageagainsthepc reviewed Jul 3, 2020

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

rageagainsthepc reviewed Jul 3, 2020

View reviewed changes

c_examples/mem-dump.c Outdated Show resolved Hide resolved

rageagainsthepc reviewed Jul 3, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Jul 3, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Jul 3, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Jul 3, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Jul 3, 2020

View reviewed changes

src/driver/kvm.rs Show resolved Hide resolved

arnabcs17b006 force-pushed the unit_tests branch 3 times, most recently from ae797c1 to 819f58e Compare August 21, 2020 07:39

rageagainsthepc reviewed Aug 21, 2020

View reviewed changes

Cargo.toml Show resolved Hide resolved

arnabcs17b006 force-pushed the unit_tests branch from 819f58e to a809d41 Compare August 21, 2020 12:09

arnabcs17b006 force-pushed the unit_tests branch from a809d41 to 32187f0 Compare August 21, 2020 12:49

rageagainsthepc reviewed Aug 21, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

arnabcs17b006 force-pushed the unit_tests branch 4 times, most recently from 6501bc4 to 327a40d Compare August 22, 2020 09:19

rageagainsthepc reviewed Aug 22, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

arnabcs17b006 force-pushed the unit_tests branch from 1f01abb to f790ce9 Compare August 24, 2020 18:00

rageagainsthepc reviewed Aug 24, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Aug 24, 2020

View reviewed changes

src/driver/kvm.rs Show resolved Hide resolved

rageagainsthepc reviewed Aug 24, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Aug 24, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Aug 24, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Aug 24, 2020

View reviewed changes

src/driver/kvm.rs Show resolved Hide resolved

rageagainsthepc reviewed Aug 24, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Aug 24, 2020

View reviewed changes

src/driver/kvm.rs Show resolved Hide resolved

arnabcs17b006 force-pushed the unit_tests branch 2 times, most recently from d4e3fd9 to dec56ae Compare August 25, 2020 13:02

rageagainsthepc reviewed Aug 25, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Aug 25, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

arnabcs17b006 force-pushed the unit_tests branch 5 times, most recently from 03ecf33 to 2947879 Compare August 25, 2020 20:32

rageagainsthepc reviewed Aug 26, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Aug 26, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Aug 26, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Aug 26, 2020

View reviewed changes

src/driver/kvm.rs Show resolved Hide resolved

rageagainsthepc reviewed Aug 26, 2020

View reviewed changes

src/driver/kvm.rs Show resolved Hide resolved

rageagainsthepc reviewed Aug 26, 2020

View reviewed changes

src/driver/kvm.rs Show resolved Hide resolved

rageagainsthepc reviewed Aug 26, 2020

View reviewed changes

src/driver/kvm.rs Outdated Show resolved Hide resolved

rageagainsthepc reviewed Aug 26, 2020

View reviewed changes

src/driver/kvm.rs Show resolved Hide resolved

unit tests added

51d3d67

arnabcs17b006 force-pushed the unit_tests branch from 2947879 to 51d3d67 Compare August 26, 2020 21:00

Wenzel added this to the Next Release milestone Dec 15, 2020

Unit tests #82

Are you sure you want to change the base?

Unit tests #82

Uh oh!

Conversation

arnabcs17b006 commented Jun 22, 2020

Uh oh!

arnabcs17b006 commented Jun 22, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wenzel commented Aug 19, 2020

Uh oh!

arnabcs17b006 commented Aug 19, 2020 via email

Uh oh!

Wenzel commented Aug 19, 2020

Uh oh!

Uh oh!

rageagainsthepc commented Aug 21, 2020

Uh oh!

rageagainsthepc commented Aug 21, 2020

Uh oh!

codecov-commenter commented Aug 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rageagainsthepc Aug 25, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov-commenter commented Aug 21, 2020 •

edited

Loading