Draft
Conversation
Cyperghost
force-pushed
the
6.3-condition
branch
3 times, most recently
from
762479e to
afd7d4b
Compare
dtdesign
requested changes
Jun 1, 2025
wcfsetup/install/files/lib/system/condition/type/IObjectConditionType.class.php
Outdated
Show resolved
Hide resolved
wcfsetup/install/files/lib/system/condition/type/user/UserUsernameConditionType.class.php
Outdated
Show resolved
Hide resolved
dtdesign
requested changes
Jun 3, 2025
ts/WoltLabSuite/Core/Form/Builder/Container/ConditionFormField.ts
Outdated
Show resolved
Hide resolved
.../install/files/lib/system/form/builder/container/PrefixConditionFormFieldContainer.class.php
Outdated
Show resolved
Hide resolved
This was referenced Jun 10, 2025
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
Co-authored-by: Alexander Ebert <ebert@woltlab.com>
If we're going to instantiate them via anonymous classes, we can just drop the `abstract` because their entire implementation is non-abstract anyway.
There is very little gain in offering `addConditions()` plus it requires us to validate an arbitrary array in contrast to relying on `addCondition()` with its type hin.
Avoiding the repetition makes it easier to find conditions.
Add phpstan docs
The content of `wcf.condition.add` has been swapped between German and English.
Cyperghost
force-pushed
the
6.3-condition
branch
from
442ae80 to
2abe329
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5984
TODO:
ConditionHandlerfunctionswcf1_user_group_assignment .conditionstoinstall.sqlSelectFormFieldso that no exception is thrown