Fix regex pattern for bbcode attachment matches#6579
Closed
SoftCreatR wants to merge 1 commit intoWoltLab:6.2from
Closed
Fix regex pattern for bbcode attachment matches#6579SoftCreatR wants to merge 1 commit intoWoltLab:6.2from
SoftCreatR wants to merge 1 commit intoWoltLab:6.2from
Conversation
Capture only digits in group 1, so parseInt(match[1], 10) works for quoted and unquoted IDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After saving, attachment BBCodes may be normalized from
[attach=1612][/attach]to[attach='1612'][/attach](or double-quoted), which caused inserted-attachment detection to fail on edit.This change updates the BBCode matcher to capture numeric IDs regardless of optional single/double quotes around the ID, so previously inserted attachments are correctly recognized in all formats.