Fix incomplete translator comments in WP_Ability and WP_Ability_Category #157
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #157 +/- ##
=============================================
- Coverage 80.46% 22.52% -57.94%
Complexity 178 178
=============================================
Files 20 20
Lines 1474 1474
Branches 120 119 -1
=============================================
- Hits 1186 332 -854
- Misses 288 1142 +854
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
(Clarifying - approving as this is indeed a docs bug + valid fix but I believe it needs to first be directly applied to |
2 participants
The translator comments in
WP_AbilityandWP_Ability_Categoryonly describe the first placeholder but the strings have three.WP_Ability (
class-wp-ability.php)Before:
/* translators: %s: Property name. */After:
/* translators: %1$s: Property name, %2$s: Ability name, %3$s: Class name. */WP_Ability_Category (
class-wp-ability-category.php)Before:
/* translators: %s: Property name. */After:
/* translators: %1$s: Property name, %2$s: Ability category slug, %3$s: Class name. */Translators using tools like translate.wordpress.org don't see the source code, so having all placeholders described helps them know what each one is.