Skip to content

Comments

Added External Link Validation for Admin Menus#1186

Open
mainulsunvi wants to merge 7 commits intoWordPress:trunkfrom
mainulsunvi:fix/admin-menu-external-link-check
Open

Added External Link Validation for Admin Menus#1186
mainulsunvi wants to merge 7 commits intoWordPress:trunkfrom
mainulsunvi:fix/admin-menu-external-link-check

Conversation

@mainulsunvi
Copy link

Hello

I’ve completed the changes to block external links in the WordPress admin menu, as discussed in issue #1184

The functionality is working as expected and ensures compliance with plugin directory guidelines.

Kindly review the changes at your convenience. If everything meets your approval, I would greatly appreciate it if we could proceed with merging this into the main branch.

Thanks for your time and consideration!

@github-actions
Copy link

github-actions bot commented Feb 17, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mainulsunvi <mainulsunvi@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: ernilambar <nilambar@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar
Copy link
Member

After Plugins Team meeting we have decided that we will only check for top level menu:

It is an issue only if it is in the top menu. In submenus it's fine to have docs, support, etc.

@mainulsunvi
Copy link
Author

Thank you for your comment, @ernilambar

I appreciate your feedback and will make the necessary adjustments to my code. I'll update you shortly.

@mainulsunvi
Copy link
Author

Hi @ernilambar

I updated the code to evaluate only the external links in the top-level admin menu.

image

@davidperezgar
Copy link
Member

Thanks for your contribution! LGTM!

@mainulsunvi
Copy link
Author

Hey @ernilambar

I revised my code based on your feedback.

✔ Updated the Version Number from 1.8.0 to 1.9.0.
✔ Revamped the Description Text.
✔ Adjusted the severity level from 9 to 7

image

Kindly review this and inform me if any adjustments are necessary.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants