Added External Link Validation for Admin Menus#1186
Added External Link Validation for Admin Menus#1186mainulsunvi wants to merge 7 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
After Plugins Team meeting we have decided that we will only check for top level menu: |
|
Thank you for your comment, @ernilambar I appreciate your feedback and will make the necessary adjustments to my code. I'll update you shortly. |
|
Hi @ernilambar I updated the code to evaluate only the external links in the top-level admin menu.
|
|
Thanks for your contribution! LGTM! |
includes/Checker/Checks/Plugin_Repo/External_Admin_Menu_Links_Check.php
Outdated
Show resolved
Hide resolved
includes/Checker/Checks/Plugin_Repo/External_Admin_Menu_Links_Check.php
Outdated
Show resolved
Hide resolved
includes/Checker/Checks/Plugin_Repo/External_Admin_Menu_Links_Check.php
Outdated
Show resolved
Hide resolved
|
Hey @ernilambar I revised my code based on your feedback. ✔ Updated the Version Number from 1.8.0 to 1.9.0.
Kindly review this and inform me if any adjustments are necessary. Thank you. |


Hello
I’ve completed the changes to block external links in the WordPress admin menu, as discussed in issue #1184
The functionality is working as expected and ensures compliance with plugin directory guidelines.
Kindly review the changes at your convenience. If everything meets your approval, I would greatly appreciate it if we could proceed with merging this into the main branch.
Thanks for your time and consideration!