-
Notifications
You must be signed in to change notification settings - Fork 3.2k
#64083 Trim the 6.7 workflows #10165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.7
Are you sure you want to change the base?
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small suggestions. But supportive of this idea.
| # Test highest and lowest supported version of each major. | ||
| php: [ '7.2', '7.4', '8.0', '8.4' ] | ||
| db-type: [ 'mariadb' ] | ||
| db-version: [ '10.4', '10.6', '10.11', '11.2' ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| db-version: [ '10.4', '10.6', '10.11', '11.2' ] | |
| db-version: [ '10.6', '10.11' ] |
11.2 was a rolling innovation release that is no longer supported. Since those releases have a short life-cycle, I lean towards saying that innovation/rolling releases are not included in test strategies for any non-supported branch.
I've also removed 10.4 here. I've opened #10166 to remove this version from trunk because usage across all WordPress sites has dropped below 1%.
| - os: ubuntu-latest | ||
| php: '7.4' | ||
| db-type: 'mariadb' | ||
| db-version: '11.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| db-version: '10.11' |
If there's agreement on the point about dropping innovation/rolling releases, these includes should be changed to the newest LTS version supported in that version.
| - os: ubuntu-latest | ||
| php: '7.4' | ||
| db-type: 'mariadb' | ||
| db-version: '11.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| db-version: '10.11' |
Same as above.
For the 6.7 branch:
Trac ticket: https://core.trac.wordpress.org/ticket/64083