Skip to content

Add Theme File Editor notice when editing a stylesheet for a block theme and warn when there is a minified version available #10279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
westonruter wants to merge 7 commits into from
Closed

Add Theme File Editor notice when editing a stylesheet for a block theme and warn when there is a minified version available #10279

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3f6dc40
Add notice to use Additional CSS in the Site Editor when using a bloc…
westonruter Oct 15, 2025
ed037a0
Add warning about editing a stylesheet when there is a minified version
westonruter Oct 15, 2025
bd06646
Remove unneeded translators comment
westonruter Oct 15, 2025
9383f2e
Remove extraneous sprintf()
westonruter Oct 15, 2025
36d9fc0
Add ID attribute
westonruter Oct 15, 2025
449b912
Use uniform translator comments for repeated strings
westonruter Oct 15, 2025
7058ee6
Use uniform translator comments for repeated strings
westonruter Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 39 additions & 13 deletions src/wp-admin/theme-editor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,19 +212,45 @@
);
}

if ( preg_match( '/\.css$/', $file ) && ! wp_is_block_theme() && current_user_can( 'customize' ) ) {
$message = '<p><strong>' . __( 'Did you know?' ) . '</strong></p><p>' . sprintf(
/* translators: %s: Link to Custom CSS section in the Customizer. */
__( 'There is no need to change your CSS here &mdash; you can edit and live preview CSS changes in the <a href="%s">built-in CSS editor</a>.' ),
esc_url( add_query_arg( 'autofocus[section]', 'custom_css', admin_url( 'customize.php' ) ) )
) . '</p>';
wp_admin_notice(
$message,
array(
'type' => 'info',
'id' => 'message',
)
);
if ( preg_match( '/\.css$/', $file ) ) {
if ( ! wp_is_block_theme() && current_user_can( 'customize' ) ) {
$message = '<p><strong>' . __( 'Did you know?' ) . '</strong></p><p>' . sprintf(
/* translators: %s: Link to add custom CSS section in either the Customizer (classic themes) or Site Editor (block themes). */
__( 'There is no need to change your CSS here &mdash; you can edit and live preview CSS changes in the <a href="%s">built-in CSS editor</a>.' ),
esc_url( add_query_arg( 'autofocus[section]', 'custom_css', admin_url( 'customize.php' ) ) )
) . '</p>';
wp_admin_notice(
$message,
array(
'type' => 'info',
'id' => 'message',
)
);
} elseif ( wp_is_block_theme() && current_user_can( 'edit_theme_options' ) ) {
$message = '<p><strong>' . __( 'Did you know?' ) . '</strong></p><p>' . sprintf(
/* translators: %s: Link to add custom CSS section in either the Customizer (classic themes) or Site Editor (block themes). */
__( 'There is no need to change your CSS here &mdash; you can edit and live preview CSS changes in the <a href="%s">built-in CSS editor</a>.' ),
esc_url( admin_url( 'site-editor.php?p=%2Fstyles&section=%2Fcss' ) )
) . '</p>';
wp_admin_notice(
$message,
array(
'type' => 'info',
'id' => 'message',
)
);
}
if ( file_exists( preg_replace( '/\.css$/', '.min.css', $file ) ) ) {
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westonruter In the development version, SCRIPT_DEBUG is set to true, so this notice does not makes sense since it loads CSS from the unminified .css file. However, in production, SCRIPT_DEBUG is false, meaning that CSS won’t be applied as it load .min.css file.

This creates a bit of a trade-off not sure if we actually need this notice in that case 🤔

Copy link
Member Author

@westonruter westonruter Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand. The issue is that the changes to style.css may not be served to visitors, depending on whether SCRIPT_DEBUG is enabled. If someone temporarily enables script debug, then they would confused why their fix no longer appears after changing the file and turning script debug off. So the warning seems important.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks for clarification.

$message = '<p><strong>' . __( 'There is a minified version of this stylesheet.' ) . '</strong></p><p>' .
__( 'It is likely that this unminified stylesheet will not be served to visitors.' ) . '</p>';
wp_admin_notice(
$message,
array(
'type' => 'warning',
'id' => 'wp-css-min-warning',
)
);
}
}
?>

Expand Down
Loading