Template activation: fix unique slug filtering #10397
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priethor
approved these changes
Oct 22, 2025
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
pento
pushed a commit
that referenced
this pull request
Oct 23, 2025
The logic introduced for the unique slug filter in [61033] is incorrect. We should return the desired slug for the `wp_template` post type. This causes any second created template targeting a certain slug to not work correctly. Developed in #10397. See #62755. Fixes #64141. Props ntsekouras, priethor. git-svn-id: https://develop.svn.wordpress.org/trunk@61054 602fd350-edb4-49c9-b593-d223f7449a82
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Oct 23, 2025
The logic introduced for the unique slug filter in [61033] is incorrect. We should return the desired slug for the `wp_template` post type. This causes any second created template targeting a certain slug to not work correctly. Developed in WordPress/wordpress-develop#10397. See #62755. Fixes #64141. Props ntsekouras, priethor. Built from https://develop.svn.wordpress.org/trunk@61054 git-svn-id: https://core.svn.wordpress.org/trunk@60390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Oct 23, 2025
The logic introduced for the unique slug filter in [61033] is incorrect. We should return the desired slug for the `wp_template` post type. This causes any second created template targeting a certain slug to not work correctly. Developed in WordPress/wordpress-develop#10397. See #62755. Fixes #64141. Props ntsekouras, priethor. Built from https://develop.svn.wordpress.org/trunk@61054 git-svn-id: http://core.svn.wordpress.org/trunk@60390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic introduced for the unique slug filter in #8063 is incorrect. We should return the desired slug for the
wp_templatepost type.Testing instructions:
Create two templates of the same type (e.g. home). Activating the second one won't take any effect on the front-end, and the template will be marked as "Custom" (instead of "Home").
Trac ticket: https://core.trac.wordpress.org/ticket/64141
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.