Skip to content

Switch the upload html bypass to a button #10429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joedolson wants to merge 7 commits into from
Closed

Switch the upload html bypass to a button #10429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
892ea5c
Switch the upload html bypass to a button
joedolson Oct 28, 2025
871c060
Stray spaces...
joedolson Oct 28, 2025
6547785
Update media.php
joedolson Oct 28, 2025
5f02731
Update media.php
joedolson Oct 28, 2025
e99144d
Set focus after switching uploaders.
joedolson Oct 28, 2025
9ff8961
Update src/js/_enqueues/vendor/plupload/handlers.js
joedolson Oct 30, 2025
5aad161
Merge branch 'trunk' into switch-uploader-to-button
joedolson Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/js/_enqueues/vendor/plupload/handlers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,9 +276,12 @@ function switchUploader( s ) {

if ( typeof( uploader ) == 'object' )
uploader.refresh();

jQuery( '#plupload-browse-button' ).trigger( 'focus' );
} else {
setUserSetting( 'uploader', '1' ); // 1 == html uploader.
jQuery( '.media-upload-form' ).addClass( 'html-uploader' );
jQuery( '#async-upload' ).trigger( 'focus' );
}
}

Expand Down Expand Up @@ -420,11 +423,11 @@ jQuery( document ).ready( function( $ ) {
target.parents( '.media-item' ).fadeOut( 200, function() {
$( this ).remove();
} );
} else if ( target.is( '.upload-flash-bypass a' ) || target.is( 'a.uploader-html' ) ) { // Switch uploader to html4.
} else if ( target.is( '.upload-flash-bypass button' ) || target.is( 'a.uploader-html' ) ) { // Switch uploader to html4.
$( '#media-items, p.submit, span.big-file-warning' ).css( 'display', 'none' );
switchUploader( 0 );
e.preventDefault();
} else if ( target.is( '.upload-html-bypass a' ) ) { // Switch uploader to multi-file.
} else if ( target.is( '.upload-html-bypass button' ) ) { // Switch uploader to multi-file.
$( '#media-items, p.submit, span.big-file-warning' ).css( 'display', '' );
switchUploader( 1 );
e.preventDefault();
Expand Down
26 changes: 10 additions & 16 deletions src/wp-admin/includes/media.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3028,27 +3028,15 @@ function wp_media_insert_url_form( $default_view = 'image' ) {
* Displays the multi-file uploader message.
*
* @since 2.6.0
*
* @global int $post_ID
*/
function media_upload_flash_bypass() {
$browser_uploader = admin_url( 'media-new.php?browser-uploader' );

$post = get_post();
if ( $post ) {
$browser_uploader .= '&post_id=' . (int) $post->ID;
} elseif ( ! empty( $GLOBALS['post_ID'] ) ) {
$browser_uploader .= '&post_id=' . (int) $GLOBALS['post_ID'];
}

?>
<p class="upload-flash-bypass">
<?php
printf(
/* translators: 1: URL to browser uploader, 2: Additional link attributes. */
__( 'You are using the multi-file uploader. Problems? Try the <a href="%1$s" %2$s>browser uploader</a> instead.' ),
$browser_uploader,
'target="_blank"'
/* translators: %s: HTML attributes for button. */
__( 'You are using the multi-file uploader. Problems? Try the <button %s>browser uploader</button> instead.' ),
'type="button" class="button-link"'
);
?>
</p>
Expand All @@ -3063,7 +3051,13 @@ function media_upload_flash_bypass() {
function media_upload_html_bypass() {
?>
<p class="upload-html-bypass hide-if-no-js">
<?php _e( 'You are using the browser&#8217;s built-in file uploader. The WordPress uploader includes multiple file selection and drag and drop capability. <a href="#">Switch to the multi-file uploader</a>.' ); ?>
<?php
printf(
/* translators: %s: HTML attributes for button. */
__( 'You are using the browser&#8217;s built-in file uploader. The WordPress uploader includes multiple file selection and drag and drop capability. <button %s>Switch to the multi-file uploader</button>.' ),
'type="button" class="button-link"'
);
?>
</p>
<?php
}
Expand Down
Loading