Skip to content

Notes: Add auth_callback for wp_note_status comment meta #10430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
t-hamano wants to merge 14 commits into from
Closed

Notes: Add auth_callback for wp_note_status comment meta #10430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
40103f7
Notes: Add auth_callback for wp_note_status comment meta
t-hamano Oct 29, 2025
27bd29d
Ensure note resolution meta is registered before each test
adamsilverstein Oct 29, 2025
29c24d7
remove test set up register meta
adamsilverstein Oct 29, 2025
5501151
move wp_create_initial_comment_meta to rest_api_init hook
adamsilverstein Oct 29, 2025
334398f
Update generated api fixtures
adamsilverstein Oct 29, 2025
4887e1b
revert fixture change
adamsilverstein Oct 29, 2025
05e386c
`get_post_embed_html()` used in fixture generation assumes `wp-includ…
adamsilverstein Oct 29, 2025
9643a5e
Revert "move wp_create_initial_comment_meta to rest_api_init hook"
adamsilverstein Oct 29, 2025
1cba839
Hook meta registration on rest_api_init so it is included for tests
adamsilverstein Oct 29, 2025
a9ffe5c
Expand test to check that meta is successfully set
adamsilverstein Oct 29, 2025
2188f3e
Fix generation of wp-api fixtures and regnerate with new meta present
adamsilverstein Oct 29, 2025
31d9ef9
iInclude _wp_note_status in expected meta when testing comment meta
adamsilverstein Oct 29, 2025
713c73c
Explicitly register comment meta in unit tests and revert the action …
t-hamano Oct 30, 2025
1c75fb9
Revert some changes
t-hamano Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/wp-includes/comment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4129,7 +4129,9 @@ function wp_create_initial_comment_meta() {
'enum' => array( 'resolved', 'reopen' ),
),
),
'auth_callback' => function ( $allowed, $meta_key, $object_id ) {
return current_user_can( 'edit_comment', $object_id );
},
)
);
}
add_action( 'init', 'wp_create_initial_comment_meta' );
1 change: 1 addition & 0 deletions src/wp-includes/default-filters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@
add_action( 'added_comment_meta', 'wp_cache_set_comments_last_changed' );
add_action( 'updated_comment_meta', 'wp_cache_set_comments_last_changed' );
add_action( 'deleted_comment_meta', 'wp_cache_set_comments_last_changed' );
add_action( 'init', 'wp_create_initial_comment_meta' );

// Places to balance tags on input.
foreach ( array( 'content_save_pre', 'excerpt_save_pre', 'comment_save_pre', 'pre_comment_content' ) as $filter ) {
Expand Down
7 changes: 7 additions & 0 deletions tests/phpunit/tests/rest-api/rest-comments-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ public static function wpTearDownAfterClass() {
public function set_up() {
parent::set_up();
$this->endpoint = new WP_REST_Comments_Controller();
wp_create_initial_comment_meta();

if ( is_multisite() ) {
update_site_option( 'site_admins', array( 'superadmin' ) );
}
Expand Down Expand Up @@ -3888,6 +3890,11 @@ public function test_create_empty_note_with_resolution_meta( $status ) {

$response = rest_get_server()->dispatch( $request );
$this->assertSame( 201, $response->get_status() );

$data = $response->get_data();
$this->assertArrayHasKey( 'meta', $data );
$this->assertArrayHasKey( '_wp_note_status', $data['meta'] );
$this->assertSame( $status, $data['meta']['_wp_note_status'] );
}

/**
Expand Down
Loading