Security: Improve admin-ajax.php action sanitization #10705
+159
−73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Props: mohammadzaid
Fixes: https://core.trac.wordpress.org/ticket/64489
Summary
Improve
$_REQUEST['action']sanitization inadmin-ajax.php.Changes
isset()+is_scalar()checkssanitize_key( wp_unslash( $_REQUEST['action'] ) )wp_die()guardTesting
npm run lint:php✅npm run test:php✅Trac: https://core.trac.wordpress.org/ticket/64489