Skip to content

Conversation

@Zaidfarooqui01
Copy link

Gutenberg/WordPress Core: Editor

Add accessibility improvements per Trac #64490:

  • Add role="dialog", aria-labelledby="link-dialog-title", and aria-modal="true" to LinkControl modal container
  • Add hidden heading id="link-dialog-title" with text "Insert Link"
  • Add aria-label="Link URL" to URLInput field
  • Add aria-label="Search links" to search input field

Tested: Chrome Accessibility Tree + NVDA screen reader

Fixes #64490

Props: mohammadzaid

See: https://core.trac.wordpress.org/ticket/64490


Add accessibility improvements per Trac #63108:

* Add role="dialog", aria-labelledby="link-dialog-title", and aria-modal="true"

* Add hidden heading with id="link-dialog-title" and text "Insert Link"

* Add aria-label="Link URL" to URL input field

* Add aria-label="Search links" to search input field

Fixes #63108.

Props: Zaidfarooqui01

See: https://core.trac.wordpress.org/ticket/63108
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mohammadzaid.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@t-hamano
Copy link
Contributor

Thanks for the PR!

Unfortunately, this PR isn't acceptable because the LinkControl component is managed at the Gutenberg repo. See https://core.trac.wordpress.org/ticket/64490#comment:2

@t-hamano t-hamano closed this Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants