Skip to content

Editor: Add ARIA labels to LinkControl dialog #10712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Zaidfarooqui01 wants to merge 2 commits into from
Closed

Editor: Add ARIA labels to LinkControl dialog #10712

Zaidfarooqui01 wants to merge 2 commits into from
+611 −0

Conversation

@Zaidfarooqui01
Copy link

@Zaidfarooqui01 Zaidfarooqui01 commented Jan 10, 2026

Trac: #63108 (Good First Bug)

Scoped ARIA labels in LinkControlSearchInput to improve accessibility.

Changes:

  • tests/phpunit/includes/bootstrap.php: Added test isolation
  • gutenberg/packages/block-editor/src/components/link-control/search-input.js: Scoped ARIA labels
  • packages/components/src/modal/index.tsx: Modal improvements

Fixes:

  • Test_WP_Customize_Custom_CSS_Setting::test_update_custom_css_updates_theme_mod

Why:
Accessibility enhancement for LinkControl dialog. Good-first-bug contribution.

Props: @Zaidfarooqui01
See: https://core.trac.wordpress.org/ticket/63108

@Zaidfarooqui01
Editor: Add ARIA labels to LinkControl dialog
586e73d 
Add accessibility improvements per Trac #63108:

* Add role="dialog", aria-labelledby="link-dialog-title", and aria-modal="true"

* Add hidden heading with id="link-dialog-title" and text "Insert Link"

* Add aria-label="Link URL" to URL input field

* Add aria-label="Search links" to search input field

Fixes #63108.

Props: Zaidfarooqui01

See: https://core.trac.wordpress.org/ticket/63108
@Zaidfarooqui01
Fix LinkControl ARIA Implementation and Remove Customizer Interference
d554962 
Scoped ARIA labels in LinkControlSearchInput to prevent side effects.
Removed potential interference with customize_register, WP_Customize_*, and theme_mod operations.
Added PHPUnit test isolation for block editor changes.

Addresses test failure: Test_WP_Customize_Custom_CSS_Setting::test_update_custom_css_updates_theme_mod
@github-actions
Copy link

github-actions bot commented Jan 10, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props mohammadzaid.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Jan 10, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Zaidfarooqui01