Fix unnecessary 301 canonical redirect for query string encoding #10724
+83
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes unnecessary 301 redirect triggered by
redirect_canonical()when a query string contains a+(plus sign) instead of%20.While both
+and%20are valid representations of a space in a query string, WordPress'sredirect_canonical()logic usesrawurlencode_deep(), which strictly follows RFC 3986 (using%20). When comparing the requested URL to the canonical candidate, the mismatch in encoding triggers a redirect. This can lead to redirect loops, increased server load, and cache poisoning in environments with edge caching.Changes
redirect_canonical()inwp-includes/canonical.phpto normalize query string encoding before comparison.+and%20as equivalent within the query string portion of the URL.Testing Instructions
example.com/?s=hello+world.example.com/?s=hello%20world.Trac ticket
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.