-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Tests: Use assertEqualHTML for semantic HTML comparison in script tests #10727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Use assertEqualHTML for semantic HTML comparison in script tests #10727
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
cbravobernal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The `assertEqualHTML()` method makes tests resilient to irrelevant syntactic changes in HTML output, focusing on semantic equivalence rather than exact string matching. Developed in #10727. Follow up to [61394], [61391]. Props jonsurrell, cbravobernal. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@61478 602fd350-edb4-49c9-b593-d223f7449a82
|
Merged in r61478. |
The `assertEqualHTML()` method makes tests resilient to irrelevant syntactic changes in HTML output, focusing on semantic equivalence rather than exact string matching. Developed in WordPress/wordpress-develop#10727. Follow up to [61394], [61391]. Props jonsurrell, cbravobernal. See #64225. Built from https://develop.svn.wordpress.org/trunk@61478 git-svn-id: http://core.svn.wordpress.org/trunk@60790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The `assertEqualHTML()` method makes tests resilient to irrelevant syntactic changes in HTML output, focusing on semantic equivalence rather than exact string matching. Developed in WordPress/wordpress-develop#10727. Follow up to [61394], [61391]. Props jonsurrell, cbravobernal. See #64225. Built from https://develop.svn.wordpress.org/trunk@61478 git-svn-id: https://core.svn.wordpress.org/trunk@60790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
assertEqualHTMLmakes the tests resilient to irrelevant syntactic changes.Extracted from #10639.
Trac ticket: https://core.trac.wordpress.org/ticket/64225
Follow up to r61394, r61391.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.