-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Scripts: Add script tag attribute handling tests #10728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Test different attribute values and types - Test repeated attributes
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| array( | ||
| 'true' => true, | ||
| 'false' => false, | ||
| 'null' => null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have always wondered if we should treat null and false values equivalently in set_attribute(). This scenario almost makes it seem important to do so, because who is going to expect the string value "null" to appear when sending a null value?
dmsnell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice touch in preparation for #10639
Add tests that verify the behavior of `wp_get_inline_script_tag()` and `wp_get_script_tag()` attribute handling. Developed in #10728. Props jonsurrell, dmsnell. See #64500. git-svn-id: https://develop.svn.wordpress.org/trunk@61482 602fd350-edb4-49c9-b593-d223f7449a82
|
Merged in r61482. |
Add tests that verify the behavior of `wp_get_inline_script_tag()` and `wp_get_script_tag()` attribute handling. Developed in WordPress/wordpress-develop#10728. Props jonsurrell, dmsnell. See #64500. Built from https://develop.svn.wordpress.org/trunk@61482 git-svn-id: http://core.svn.wordpress.org/trunk@60794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Add tests that verify the behavior of `wp_get_inline_script_tag()` and `wp_get_script_tag()` attribute handling. Developed in WordPress/wordpress-develop#10728. Props jonsurrell, dmsnell. See #64500. Built from https://develop.svn.wordpress.org/trunk@61482 git-svn-id: https://core.svn.wordpress.org/trunk@60794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Add tests that verify the behavior of
wp_get_inline_script_tag()wp_get_script_tag()attribute handling. This is relevant for the work in #10639. See #10639 (comment).Tests are added using
assertEqualHTML()assertions that verify the behavior when:Trac ticket: https://core.trac.wordpress.org/ticket/64500
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.