Skip to content

Conversation

@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Jan 21, 2026

Summary

  • Replace https.request() with native fetch() in log-results.js
  • Properly follow HTTP redirects (301/302)
  • Exit with non-zero code on non-2xx responses

Problem

The performance results logging script would silently succeed even when the API returned a redirect or error response, causing performance results to be lost without any indication in CI.

Solution

Use native fetch() (Node 18+) which automatically follows redirects and check response.ok to properly fail on error responses.

Trac ticket: https://core.trac.wordpress.org/ticket/64534


🤖 Generated with Claude Code

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props youknowriad.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@youknowriad youknowriad requested review from ellatrix and mcsf January 21, 2026 10:39
@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@youknowriad
Copy link
Contributor Author

youknowriad commented Jan 21, 2026

This actually doesn't solve the issue as it is, follow redirect doesn't work as intended for "post" request (the body is dropped). Let me try to figure out an alternative (maybe use the non redirected url directly)

Replace `https.request()` with native `fetch()` in `log-results.js` to properly handle HTTP redirects and non-2xx responses. Also removes `www.` from the CodeVitals host to avoid unnecessary redirects.

Previously, the script would silently succeed even when the API returned a redirect (301/302) or error response, causing performance results to be lost without any indication in CI.

Props youknowriad.
Fixes #XXXXX.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
BASE_SHA: ${{ steps.base-sha.outputs.result }}
CODEVITALS_PROJECT_TOKEN: ${{ secrets.CODEVITALS_PROJECT_TOKEN }}
HOST_NAME: www.codevitals.run
HOST_NAME: codevitals.run
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes avoid the redirects

@youknowriad
Copy link
Contributor Author

Ok I think this works now, only way to actually test though is to commit.

Copy link

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants