-
Notifications
You must be signed in to change notification settings - Fork 3.2k
HTML Processor: Increase MAX_BOOKMARKS #10820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
HTML Processor: Increase MAX_BOOKMARKS #10820
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
dmsnell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my own testing I found that 3,000 was sufficient to parse all but the most extreme documents, and 6,000 I believe was sufficient to parse the home page of the 300,000 most-visited domains.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Bookmark exhaustion has been observed on fairly standard WordPress post content. This is partially related to WordPress/gutenberg#70542 which may nest formatting elements to extreme depths.
The initial limit of 100 bookmarks was very conservative. A significant increase in bookmarks seems to perform well without excessive memory usage.
Related to #10616.
Trac ticket: https://core.trac.wordpress.org/ticket/64394
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.