-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Bundled themes: Add missing path data for enqueued stylesheet in block themes so they can be inlined (and add minification)
#8396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
path data for theme stylesheet so it can be inlined and add minificationpath data for enqueued stylesheet in block themes so they can be inlined (and add minification)
Co-authored-by: Stephen A. Bernhardt <sabernhardt@git.wordpress.org>
Trac ticket: https://core.trac.wordpress.org/ticket/63007
This allows for
style.cssfrom Twenty Twenty-Two and Twenty Twenty-Five to be inlined so as to eliminate a render-blocking resource from the page. See Core-63007 for impact metrics on LCP.This also introduces minification for
style.cssto reduce the size of the stylesheets in the two core block themes that use them:style.csssizestyle.min.csssizeThis is important when the overall limit for inlining CSS (
styles_inline_size_limit) is by default 20,000 bytes. The same scheme is used for core, where the file extension.min.cssis used for the minified files. (It would be nice if a sourcemap were generated as well.)I'm not sure if this is the right place to introduce the minification, as perhaps it should be part of the theme's own build process. Also, ideally other themes would also have their stylesheets minified (see comment on Core-49665).
HTML Diffs
Twenty Twenty-Two
Twenty Twenty-Two with
SCRIPT_DEBUGenabledTwenty Twenty-Two with
SCRIPT_DEBUGdisabledTwenty Twenty-Five
Twenty Twenty-Five with
SCRIPT_DEBUGenabledTwenty Twenty-Five with
SCRIPT_DEBUGdisabledThis Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.