Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
@SirLouen is there anything left to do here? |
|
@mindctrl yeah this is still of phase 1. |
|
@SirLouen could you add a list of things left to do in the opening description? We have a 6.9 milestone and I'd love to help get it in the proper state for a committer to review/merge. I've needed local mail testing multiple times recently. WCUS Contributor Day is coming up and I know a few people willing to help. |
|
@mindctrl I think it's time to de-milestone this. I was confident that this could be a great addition to My idea is to look to add extra value to this, but this is not going to happen anytime soon, and I seriously doubt it will make it on time for 6.9. This PR by itself is useful for someone like me that uses this PR like every other day, but useless for most of the people that seldom test anything—mail. Hope to see it merged somewhere in the future, but much work is needed to consider it a potential merge (mainly creating integration tests in PHPUnit that make use of this service). I've updated the milestone so we don't need to rush it anymore. |
Adding support for a Mailpit container on demand with the env variable:
LOCAL_MAILPatch Testing instructions:
LOCAL_MAIL=falsetoLOCAL_MAIL=truein your.envfilenpm run env:startA) Go to http://localhost:8025/
B) You can run in your wordpress-develop container
docker exec -it wordpress-develop-php-1 openssl s_client -connect mailhog:1025And it might result in something like:
C) You can do further tests, like sending an email with a plugin that uses the local mailhog hostname
For example this one: https://github.com/SirLouen/amazon-s3-email-testing/archive/refs/tags/1.0.0.zip
Trac ticket: https://core.trac.wordpress.org/ticket/63135
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.