Skip to content

Conversation

@nikunj8866
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/48345


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @nhatkar@updraftplus.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props nikunj8866, joedolson, sirlouen, westonruter, praful2111.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@nikunj8866
Copy link
Author

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @nhatkar@updraftplus.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Please use @nikunj8866 WordPress profile.

@nikunj8866
Copy link
Author

After

image

@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@nikunj8866 nikunj8866 requested a review from SirLouen July 1, 2025 13:45
Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some style things I'd like to see changed for consistency with color palette, an accessibility issue, and the browser detection needs some work.

@nikunj8866 nikunj8866 requested a review from joedolson September 9, 2025 13:40
Copy link
Contributor

@joedolson joedolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer!

@praful2111
Copy link

praful2111 commented Oct 17, 2025

Tested with the below config

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: (#8726)

Environment

  • WordPress: 6.9-alpha-20250922.141940
  • PHP: 7.4.31-dev
  • Server: PHP.wasm
  • Database: WP_SQLite_Driver (Server: 5.5 / Client: 3.40.1)
  • Browser: Chrome 141.0.0.0
  • OS: Linux
  • Theme: Twenty Twenty-Five 1.3
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ✅ Issue resolved with patch.

Additional Notes

  • Any additional details worth mentioning.

Supplemental Artifacts

Chrome
image

Comet
image

Firefox
image

User Profile
image

I have some additional changes I want to make to this and haven't seen any activity from @nikunj8866 recently.
Move caps lock warning output to JS to reduce code duplication; fix issue where changes were not registered in capslock key pressed; improve comments; styling changes.
@joedolson joedolson dismissed their stale review October 19, 2025 18:58

obsolete

@joedolson joedolson requested a review from westonruter October 19, 2025 18:58
@joedolson
Copy link
Contributor

Screenshots:

user profile page with capslock warning visible user login with capslock warning visible

Co-authored-by: Weston Ruter <westonruter@gmail.com>
@joedolson
Copy link
Contributor

Closed in r60988

@joedolson joedolson closed this Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants