-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add Caps lock message to login screen #8726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Caps lock message to login screen #8726
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @nhatkar@updraftplus.com. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Please use @nikunj8866 WordPress profile. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
…es and used KeyboardEvent.getModifierState() for checking
joedolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some style things I'd like to see changed for consistency with color palette, an accessibility issue, and the browser detection needs some work.
joedolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting closer!
|
Tested with the below config Test ReportDescriptionThis report validates whether the indicated patch works as expected. Patch tested: (#8726) Environment
Actual Results
Additional Notes
Supplemental Artifacts |
I have some additional changes I want to make to this and haven't seen any activity from @nikunj8866 recently.
Move caps lock warning output to JS to reduce code duplication; fix issue where changes were not registered in capslock key pressed; improve comments; styling changes.
Co-authored-by: Weston Ruter <westonruter@gmail.com>
|
Closed in r60988 |







Trac ticket: https://core.trac.wordpress.org/ticket/48345
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.