Skip to content

Fix: #57170 Invalid Menu Item Parent#9222

Open
DarkMatter-999 wants to merge 4 commits intoWordPress:trunkfrom
DarkMatter-999:57170-fix-invalid-menu-item-parent
Open

Fix: #57170 Invalid Menu Item Parent#9222
DarkMatter-999 wants to merge 4 commits intoWordPress:trunkfrom
DarkMatter-999:57170-fix-invalid-menu-item-parent

Conversation

@DarkMatter-999
Copy link

Trac ticket: https://core.trac.wordpress.org/ticket/57170


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Before:

Screen.Recording.2025-07-09.at.3.34.07.PM.mp4

After:

Screen.Recording.2025-07-09.at.3.35.44.PM.mp4

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props lakshyajeet, azaozz, shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@azaozz
Copy link
Contributor

azaozz commented Aug 25, 2025

Looks good here. Thanks for the videos :)

@azaozz azaozz self-requested a review August 25, 2025 23:16
* @param {Object} itemToRefresh The menu item that might need its advanced accessibility buttons refreshed
*
*
* @since 6.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can We add @since 6.6.0 before @param {Object} itemToRefresh The menu item that might need its advanced accessibility buttons refreshed. ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants