-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Limit the number of jobs that spawn for forks #9324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3a624d8
Run a limited number of test combinations on forks
desrosj 35e20e7
Pare down test combinations more.
desrosj e3e121d
Disable install testing on forks.
desrosj 6682e5f
Disable local environment testing on forks.
desrosj 1ae2b8f
Disable upgrade testing on forks.
desrosj 65bd314
Don't confirm Gutenberg build process in forks.
desrosj 5ec2f07
Don't create and upload theme Zip files on forks.
desrosj 1c5149b
Exclude non-existent combinations.
desrosj e08b9bd
Exclude memcache jobs in forks.
desrosj 228e585
The `matrix` context is not available within `if`
desrosj ad6613d
Add a limited number of upgrade tests.
desrosj e9a58db
Remove new condition for performance workflow.
desrosj b01cd49
Add some inline docs.
desrosj 4439ce8
Adjust conditions for upgrade develop testing.
desrosj 7f9f932
Fix typo in context value.
desrosj 6cdc7f7
Avoid testing the build process on Windows in forks
desrosj 9f378b1
Run the full test suite on organization forks.
desrosj 022f658
Merge remote-tracking branch 'upstream/trunk' into limit-jobs-for-for…
desrosj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -47,14 +47,15 @@ jobs: | |||
| build: | ||||
| name: Build | ||||
| uses: ./.github/workflows/reusable-build-package.yml | ||||
| if: ${{ startsWith( github.repository, 'WordPress/' ) && ( github.repository == 'WordPress/wordpress-develop' || ( github.event_name == 'pull_request' && github.actor != 'dependabot[bot]' ) ) }} | ||||
| permissions: | ||||
| contents: read | ||||
|
|
||||
| # Run upgrade tests for the current branch. | ||||
| upgrade-tests-develop: | ||||
| name: Upgrade from ${{ matrix.wp }} | ||||
| uses: ./.github/workflows/reusable-upgrade-testing.yml | ||||
| if: ${{ github.repository == 'WordPress/wordpress-develop' || ( github.event_name == 'pull_request' && github.actor != 'dependabot[bot]' ) }} | ||||
| if: ${{ github.repository == 'WordPress/wordpress-develop' }} | ||||
| needs: [ build ] | ||||
| strategy: | ||||
| fail-fast: false | ||||
|
|
@@ -83,6 +84,36 @@ jobs: | |||
| new-version: develop | ||||
| multisite: ${{ matrix.multisite }} | ||||
|
|
||||
| # Run a limited set of upgrade tests for the current branch on forks. | ||||
| upgrade-tests-develop-forks: | ||||
| name: Upgrade from ${{ matrix.wp }} | ||||
| uses: ./.github/workflows/reusable-upgrade-testing.yml | ||||
| if: ${{ github.repository != 'WordPress/wordpress-develop' }} | ||||
| needs: [ build ] | ||||
| strategy: | ||||
| fail-fast: false | ||||
| matrix: | ||||
| os: [ 'ubuntu-24.04' ] | ||||
| php: [ '7.2', '8.4' ] | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Noting that this should be 7.4instead of 7.2 if #9181 lands first |
||||
| db-type: [ 'mysql' ] | ||||
| db-version: [ '8.4' ] | ||||
| # WordPress 4.9 is the oldest version that supports PHP 7.2. | ||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
This looks like just copy paste rather than necessary based on the matrix |
||||
| wp: [ '6.7', '6.8' ] | ||||
| multisite: [ false, true ] | ||||
|
|
||||
| exclude: | ||||
| # The PHP <= 7.3/MySQL 8.4 jobs currently fail due to mysql_native_password being disabled by default. See https://core.trac.wordpress.org/ticket/61218. | ||||
| - php: '7.2' | ||||
| db-version: '8.4' | ||||
| with: | ||||
| os: ${{ matrix.os }} | ||||
| php: ${{ matrix.php }} | ||||
| db-type: ${{ matrix.db-type }} | ||||
| db-version: ${{ matrix.db-version }} | ||||
| wp: ${{ matrix.wp }} | ||||
| new-version: develop | ||||
| multisite: ${{ matrix.multisite }} | ||||
|
|
||||
| slack-notifications: | ||||
| name: Slack Notifications | ||||
| uses: ./.github/workflows/slack-notifications.yml | ||||
|
|
||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that this should be
7.4instead of 7.2 if #9181 lands first