Fix: Update Raw `<script>` tags with `wp_inline_script_tag()` for bundled themes. #9416

Debarghya-Banerjee · 2025-08-11T07:01:07Z

This pull request updates all inline script outputs in the bundled themes to use WordPress’s script helper functions, specifically wp_print_inline_script_tag(), in place of manually constructed <script> tags.

✅ Why This Matters

As of #59446, WordPress Core has adopted the use of wp_get_script_tag(), wp_get_inline_script_tag(), and wp_print_inline_script_tag() to eliminate manually constructed <script> tags. This change was made to:

However, many default and third-party themes still use raw <script> tags, which prevents them from fully benefiting from these improvements.

🛠 What’s Changed

Replaced all instances of echo '<script>...</script>' with calls to wp_print_inline_script_tag().
Added a fallback check: if the helper function does not exist, the code directly prints the <script> tag.

🔙 Backward Compatibility

On WordPress 5.7+, the new helper functions are used.
On earlier versions, where these functions do not exist, the scripts fall back to directly printing raw <script> tags.

…ction definition for backward compatibility

github-actions · 2025-08-11T07:01:16Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee, westonruter, hbhalodia, peterwilsoncc, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2025-08-11T07:15:58Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

hbhalodia

Can we add the requested changes?

src/wp-content/themes/twentyfifteen/functions.php

src/wp-content/themes/twentynineteen/functions.php

peterwilsoncc

I've added a few notes inline.

🔢 indicates the comment applies to similar code in other files too.

src/wp-content/themes/twentyfifteen/functions.php

…ipt_tag

westonruter · 2025-09-19T00:53:28Z

@Debarghya-Banerjee Hello! Have you seen the latest PR feedback yet?

Also, note the comment I just added to the ticket, related the changes to Core-63887.

Debarghya-Banerjee · 2025-09-22T10:50:57Z

Hi @westonruter , I have checked the comments and feedback, I am working on it, and will push the changes in sometime by today itself. Thanks.

Debarghya-Banerjee · 2025-09-23T19:54:41Z

Hi @westonruter , Apologies for the late update. I’ve pushed the changes based on your and @sabernhardt 's feedback. Could you please take a look? Thanks!

…ipt_tag

src/wp-content/themes/twentyfifteen/functions.php

src/wp-content/themes/twentyseventeen/functions.php

src/wp-content/themes/twentysixteen/inc/customizer.php

src/wp-content/themes/twentysixteen/functions.php

src/wp-content/themes/twentytwenty/inc/template-tags.php

src/wp-content/themes/twentysixteen/inc/customizer.php

src/wp-content/themes/twentysixteen/functions.php

src/wp-content/themes/twentyseventeen/functions.php

src/wp-content/themes/twentytwentyone/inc/template-functions.php

src/wp-content/themes/twentytwentyone/functions.php

westonruter · 2025-10-07T00:59:19Z

@Debarghya-Banerjee Are you planning to address the remaining feedback or should we start pushing up commits to this PR? Thanks!

Debarghya-Banerjee · 2025-10-07T07:11:50Z

Hi @westonruter , I have addressed the feedback. Sorry for getting back late. Can you please check once? Thanks.

…ipt_tag

…ists

This reverts commit 186e543.

westonruter · 2025-10-07T22:26:22Z

I wrote a script that checked the output of rendered output of the homepages for each of the themes to verify that there were no regressions in the generated markup, and that only the expected changes occur:

grab-output.sh

#!/bin/bash

outdir=/tmp/trac-63806-output
mkdir -p "$outdir"
echo '' > "$outdir/report.md"

check_theme() {
	theme="$1"
	url="$2"
	theme_dir="/tmp/trac-63806-output/$1"
	echo "# $theme" >> "$outdir/report.md"
	mkdir -p "$theme_dir"
	npm run env:cli theme activate "$theme"
	git checkout trunk
	curl -s "$url" > "$theme_dir/before.html"
	git checkout fix/63806-update-themes-to-use-wp_print_script_tag
	curl -s "$url" > "$theme_dir/after.html"
	prettier "$theme_dir/before.html" > "$theme_dir/before.prettier.html"
	prettier "$theme_dir/after.html" > "$theme_dir/after.prettier.html"
	diff -u "$theme_dir/before.html" "$theme_dir/after.html" > "$theme_dir/raw.diff"
	diff -u "$theme_dir/before.prettier.html" "$theme_dir/after.prettier.html" > "$theme_dir/prettier.diff"

	{
		echo "URL: \`$url\`"
		echo
		echo 'Prettier Diff:'
		echo '```diff'
		cat "$theme_dir/prettier.diff"
		echo '```'
		echo
		echo '<details><summary>Raw Diff</summary>'
		echo
		echo '```diff'
		cat "$theme_dir/raw.diff"
		echo '```'
		echo
		echo '</details>'
		echo
	} >> "$outdir/report.md"
}

home_url="http://localhost:8000/?enable_plugins=none"

check_theme twentyfifteen "$home_url"
check_theme twentyseventeen "$home_url"
check_theme twentysixteen "$home_url"
check_theme twentytwenty "$home_url"
check_theme twentytwentyone "$home_url"

cat "$outdir/report.md"

Here is the output:

twentyfifteen