Skip to content

#64227 Increase the specificity of workflow path filtering #9457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnbillion wants to merge 9 commits into
base: trunk
Choose a base branch
from
Open

#64227 Increase the specificity of workflow path filtering #9457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b2b9589
Increase the specificity of the path filtering for workflows.
johnbillion Aug 12, 2025
c0548be
Add some missing files to the path filtering.
johnbillion Aug 12, 2025
142f1a2
Fix some typos.
johnbillion Aug 14, 2025
f2a751b
Add cert files to the path filter for running the build process tests.
johnbillion Aug 14, 2025
552a7c4
Merge branch 'trunk' into 63170-paths
johnbillion Sep 3, 2025
fee8718
Update .github/workflows/coding-standards.yml
johnbillion Sep 3, 2025
7bad4cf
Fixes.
johnbillion Sep 3, 2025
652699c
Docs.
johnbillion Sep 3, 2025
ac253e9
Don't exclude these workflows when PHP files in the root are changed.
johnbillion Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/check-built-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,10 @@ on:
- '6.[8-9]'
- '[7-9].[0-9]'
paths:
# Any change to a CSS, JavaScript, JSON, or SASS file should run checks.
- '**.css'
- '**.js'
- '**.json'
- '**.sass'
# Any change to a source CSS, JavaScript, or JSON file should run checks.
- 'src/**.css'
- 'src/**.js'
- 'src/**.json'
# These files configure npm and the task runner. Changes could affect the outcome.
- 'package*.json'
- '.npmrc'
Expand Down
13 changes: 8 additions & 5 deletions .github/workflows/coding-standards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,20 @@ on:
- '3.[89]'
- '[4-9].[0-9]'
paths:
# Any change to a PHP or JavaScript file should run checks.
- '**.js'
- '**.php'
# Any change to a relevant PHP or JavaScript file should run checks.
- 'src/**.js'
- 'src/**.php'
- '*.php' # PHP files in the root, like wp-config-sample.php.
- 'tests/**.php'
- 'tests/qunit/**.js'
# These files configure npm. Changes could affect the outcome.
- 'package*.json'
- '.npmrc'
- '.nvmrc'
# These files configure Composer. Changes could affect the outcome.
- 'composer.*'
# This file configures JSHint. Changes could affect the outcome.
- '.jshintrc'
# These files configures JSHint. Changes could affect the outcome.
- '**.jshintrc'
# This file configures PHPCS. Changes could affect the outcome.
- 'phpcs.xml.dist'
# Confirm any changes to relevant workflow files.
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/end-to-end-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ on:
- '5.[3-9]'
- '[6-9].[0-9]'
paths:
# Any change to a PHP, CSS, or JavaScript file should run checks.
- '**.css'
- '**.js'
- '**.php'
# Any change to a source PHP, CSS, JavaScript, or JSON file should run checks.
- 'src/**.css'
- 'src/**.js'
- 'src/**.json'
- 'src/**.php'
- '*.php' # PHP files in the root, like wp-config-sample.php.
# These files configure npm and the task runner. Changes could affect the outcome.
- 'package*.json'
- '.npmrc'
Expand All @@ -31,7 +33,7 @@ on:
- 'tools/webpack/**'
# These files configure Composer. Changes could affect the outcome.
- 'composer.*'
# This files affect the e2e tests. Changes could affect the outcome.
# These files affect the e2e tests. Changes could affect the outcome.
- 'tests/e2e/**'
# Confirm any changes to relevant workflow files.
- '.github/workflows/end-to-end-tests.yml'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/javascript-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ on:
- '3.[89]'
- '[4-9].[0-9]'
paths:
# Any change to a JavaScript file should run tests.
- '**.js'
# Any change to a source JavaScript file should run tests.
- 'src/**.js'
# These files configure npm and the task runner. Changes could affect the outcome.
- 'package*.json'
- '.npmrc'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/local-docker-environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ on:
- 'docker-compose.yml'
# Any changes to local environment related files
- 'tools/local-env/**'
- 'wp-cli.yml'
# These files configure npm and the task runner. Changes could affect the outcome.
- 'package*.json'
- 'Gruntfile.js'
Expand All @@ -38,6 +39,7 @@ on:
- 'docker-compose.yml'
# Any changes to local environment related files
- 'tools/local-env/**'
- 'wp-cli.yml'
# These files configure npm and the task runner. Changes could affect the outcome.
- 'package*.json'
- 'Gruntfile.js'
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/performance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,12 @@ on:
- '6.[2-9]'
- '[7-9].[0-9]'
paths:
# Any change to a PHP, CSS, or JavaScript file should run checks.
- '**.css'
- '**.js'
- '**.php'
# Any change to a source PHP, CSS, JavaScript, or JSON file should run checks.
- 'src/**.css'
- 'src/**.js'
- 'src/**.json'
- 'src/**.php'
- '*.php' # PHP files in the root, like wp-config-sample.php.
# These files configure npm and the task runner. Changes could affect the outcome.
- 'package*.json'
- '.npmrc'
Expand All @@ -30,7 +32,7 @@ on:
- 'tools/webpack/**'
# These files configure Composer. Changes could affect the outcome.
- 'composer.*'
# This files affect the performance tests. Changes could affect the outcome.
# These files affect the performance tests. Changes could affect the outcome.
- 'tests/performance/**'
# Confirm any changes to relevant workflow files.
- '.github/workflows/performance.yml'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/php-compatibility.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ on:
- '5.[5-9]'
- '[6-9].[0-9]'
paths:
# This workflow only scans PHP files.
- '**.php'
# This workflow only scans source PHP files.
- 'src/**.php'
# These files configure Composer. Changes could affect the outcome.
- 'composer.*'
# This file configures PHP compatibility scanning. Changes could affect the outcome.
Expand Down
16 changes: 9 additions & 7 deletions .github/workflows/phpunit-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,24 @@ on:
- '3.[7-9]'
- '[4-9].[0-9]'
paths:
# Any change to a PHP, CSS, JavaScript, JSON, HTML, or otherwise tested file should run checks.
- '**.css'
- '**.html'
- '**.js'
- '**.json'
- '**.php'
# Any change to a source PHP, CSS, JavaScript, JSON, HTML, or otherwise tested file should run checks.
- 'src/**.css'
- 'src/**.html'
- 'src/**.js'
- 'src/**.json'
- 'src/**.php'
- 'src/license.txt'
- 'src/SECURITY.md'
- '*.php' # PHP files in the root, like wp-config-sample.php.
# These files configure npm and the task runner. Changes could affect the outcome.
- 'package*.json'
- '.npmrc'
- '.nvmrc'
- 'Gruntfile.js'
# These files configure Composer. Changes could affect the outcome.
- 'composer.*'
# This files affect the phpunit tests. Changes could affect the outcome.
# These files affect the phpunit tests. Changes could affect the outcome.
- 'phpunit.xml.dist'
- 'tests/phpunit/**'
# Confirm any changes to relevant workflow files.
- '.github/workflows/phpunit-tests.yml'
Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/test-build-processes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,13 @@ on:
- '3.[7-9]'
- '[4-9].[0-9]'
paths:
# Any change to a PHP, CSS, JavaScript, or JSON file should run checks.
- '**.css'
- '**.js'
- '**.json'
- '**.php'
# Any change to a source PHP, CSS, JavaScript, JSON, or certificate file should run checks.
- 'src/**.css'
- 'src/**.js'
- 'src/**.json'
- 'src/**.php'
Copy link
Member

@desrosj desrosj Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnbillion What do you think about removing the composer.* pattern here? The only dependency managed in Composer that is used in the build process is composer/ca-bundle. But the build process will never be affected by this without first manually updating the version (it's pinned to an exact version vs. using a semantic range) AND running grunt certificates:upgrade.

Otherwise, the only files related to certificates that would affect the build process are the .pem and .crt files that are in src/wp-includes/certificates. It may be worth adding **/*.pem and **/*.crt to this list of path filters for those scenarios.

- 'src/**.pem'
- 'src/**.crt'
# These files configure npm and the task runner. Changes could affect the outcome.
- 'package*.json'
- '.npmrc'
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/upgrade-develop-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ on:
paths:
# Any change to a source PHP file should run checks.
- 'src/**.php'
- '*.php' # PHP files in the root, like wp-config-sample.php.
# Confirm any changes to relevant workflow files.
- '.github/workflows/upgrade-develop-testing.yml'
- '.github/workflows/reusable-upgrade-testing.yml'
Expand All @@ -26,6 +27,7 @@ on:
paths:
# Any change to a source PHP file should run checks.
- 'src/**.php'
- '*.php' # PHP files in the root, like wp-config-sample.php.
# Confirm any changes to relevant workflow files.
- '.github/workflows/upgrade-develop-testing.yml'
- '.github/workflows/reusable-upgrade-testing.yml'
Expand Down
Loading