Skip to content

Hide or set empty alternatives for pseudo elements #9700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joedolson wants to merge 5 commits into from
Closed

Hide or set empty alternatives for pseudo elements #9700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
15fbf63
Hide or set empty alternatives for pseudo elements
joedolson Sep 1, 2025
5594079
Merge branch 'trunk' into scrub-pseudo-elements
joedolson Sep 20, 2025
1815244
Merge branch 'trunk' into scrub-pseudo-elements
joedolson Sep 28, 2025
bc7517f
Revert changes to vendor files.
joedolson Sep 28, 2025
a4cbca7
Update theme.js
joedolson Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/_enqueues/wp/editor/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1273,7 +1273,7 @@ window.wp = window.wp || {};

var $addMediaButton = $( '<button type="button" class="button insert-media add_media">' );

$addMediaButton.append( '<span class="wp-media-buttons-icon"></span>' );
$addMediaButton.append( '<span class="wp-media-buttons-icon" aria-hidden="true"></span>' );
$addMediaButton.append( document.createTextNode( ' ' + buttonText ) );
$addMediaButton.data( 'editor', id );

Expand Down
2 changes: 1 addition & 1 deletion src/js/_enqueues/wp/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,7 +1221,7 @@ themes.view.Themes = wp.Backbone.View.extend({

// 'Add new theme' element shown at the end of the grid.
if ( ! themes.isInstall && themes.data.settings.canInstall ) {
this.$el.append( '<div class="theme add-new-theme"><a href="' + themes.data.settings.installURI + '"><div class="theme-screenshot"><span></span></div><h2 class="theme-name">' + l10n.addNew + '</h2></a></div>' );
this.$el.append( '<div class="theme add-new-theme"><a href="' + themes.data.settings.installURI + '"><div class="theme-screenshot"><span aria-hidden="true"></span></div><h2 class="theme-name">' + l10n.addNew + '</h2></a></div>' );
}

this.parent.page++;
Expand Down
28 changes: 14 additions & 14 deletions src/wp-admin/css/customize-controls.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ body.trashing #publish-settings {
display: inline-block;
}
#customize-control-trash_changeset .button-link:before {
content: "\f182";
content: "\f182" / '';
font: normal 22px dashicons;
text-decoration: none;
position: absolute;
Expand Down Expand Up @@ -594,7 +594,7 @@ body.trashing #publish-settings {

#customize-theme-controls .accordion-section-title:after,
#customize-outer-theme-controls .accordion-section-title:after {
content: "\f345";
content: "\f345" / '';
color: #a7aaad;
pointer-events: none;
}
Expand Down Expand Up @@ -931,7 +931,7 @@ h3.customize-section-title {

.customize-controls-close:before {
font: normal 22px/45px dashicons;
content: "\f335";
content: "\f335" / '';
position: relative;
top: -3px;
left: 13px;
Expand All @@ -940,7 +940,7 @@ h3.customize-section-title {
.customize-panel-back:before,
.customize-section-back:before {
font: normal 20px/72px dashicons;
content: "\f341";
content: "\f341" / '';
position: relative;
left: 9px;
}
Expand Down Expand Up @@ -1026,7 +1026,7 @@ p.customize-section-description {

.customize-section-description a.external-link:after {
font: 16px/11px dashicons;
content: "\f504";
content: "\f504" / '';
top: 3px;
position: relative;
padding-left: 3px;
Expand Down Expand Up @@ -1357,7 +1357,7 @@ p.customize-section-description {
}

.customize-control .dropdown-arrow:after {
content: "\f140";
content: "\f140" / '';
font: normal 20px/1 dashicons;
speak: never;
display: block;
Expand Down Expand Up @@ -1882,7 +1882,7 @@ p.customize-section-description {
}

.themes-filter-bar .feature-filter-toggle:before {
content: "\f111";
content: "\f111" / '';
margin: 0 5px 0 0;
font: normal 16px/1 dashicons;
vertical-align: text-bottom;
Expand Down Expand Up @@ -2020,7 +2020,7 @@ p.customize-section-description {
}

.control-panel-themes .theme-section .customize-themes-section-title.selected:after {
content: "\f147";
content: "\f147" / '';
font: 16px/1 dashicons;
box-sizing: border-box;
width: 20px;
Expand Down Expand Up @@ -2523,7 +2523,7 @@ body.cheatin p {
.add-new-widget:before,
.add-new-menu-item:before,
#available-menu-items .new-content-item .add-content:before {
content: "\f132";
content: "\f132" / '';
display: inline-block;
position: relative;
left: -2px;
Expand Down Expand Up @@ -2602,12 +2602,12 @@ body.cheatin p {

.move-widget-down:before,
.menus-move-down:before {
content: "\f347";
content: "\f347" / '';
}

.move-widget-up:before,
.menus-move-up:before {
content: "\f343";
content: "\f343" / '';
}

#customize-theme-controls .first-widget .move-widget-up,
Expand Down Expand Up @@ -2767,7 +2767,7 @@ body.adding-widget .add-new-widget:before,

#available-widgets-filter .clear-results:before,
#available-menu-items-search .clear-results:before {
content: "\f335";
content: "\f335" / '';
font: normal 20px/1 dashicons;
vertical-align: middle;
-webkit-font-smoothing: antialiased;
Expand Down Expand Up @@ -2978,14 +2978,14 @@ body.adding-widget .add-new-widget:before,
.customize-controls-preview-toggle .preview:before,
.customize-controls-preview-toggle .controls:before {
font: normal 20px/1 dashicons;
content: "\f177";
content: "\f177" / '';
position: relative;
top: 4px;
margin-right: 6px;
}

.customize-controls-preview-toggle .controls:before {
content: "\f540";
content: "\f540" / '';
}

.preview-only #customize-controls {
Expand Down
14 changes: 7 additions & 7 deletions src/wp-admin/css/customize-nav-menus.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,11 @@
}

.menus-move-left:before {
content: "\f341";
content: "\f341" / '';
}

.menus-move-right:before {
content: "\f345";
content: "\f345" / '';
}

.reordering .menu-item .item-controls,
Expand Down Expand Up @@ -177,7 +177,7 @@
}

.wp-customizer .menu-item.menu-item-edit-active .item-edit .toggle-indicator:before {
content: "\f142";
content: "\f142" / '';
}

.wp-customizer .menu-item-settings p.description {
Expand Down Expand Up @@ -277,7 +277,7 @@
.customize-screen-options-toggle:before {
-moz-osx-font-smoothing: grayscale;
border: none;
content: "\f111";
content: "\f111" / '';
display: block;
font: 18px/1 dashicons;
padding: 5px;
Expand Down Expand Up @@ -467,7 +467,7 @@
}

.menu-item-bar .item-delete:before {
content: "\f335";
content: "\f335" / '';
position: absolute;
top: 9px;
left: 5px;
Expand Down Expand Up @@ -652,7 +652,7 @@
}

#available-menu-items .item-add:before {
content: "\f543";
content: "\f543" / '';
position: relative;
left: 2px;
top: 3px;
Expand All @@ -670,7 +670,7 @@
}

#available-menu-items .menu-item-handle.item-added .item-add:before {
content: "\f147";
content: "\f147" / '';
}

#available-menu-items .accordion-section-title.loading .spinner,
Expand Down
70 changes: 35 additions & 35 deletions src/wp-admin/css/customize-widgets.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
}

.move-widget:before {
content: "\f504";
content: "\f504" / '';
}

#customize-theme-controls .move-widget-area {
Expand Down Expand Up @@ -170,7 +170,7 @@

#customize-theme-controls .widget-area-select li:before {
display: none;
content: "\f147";
content: "\f147" / '';
position: absolute;
top: 12px;
left: 10px;
Expand Down Expand Up @@ -292,7 +292,7 @@ body.adding-widget #customize-preview {
}

#available-widgets .widget-title:before {
content: "\f132";
content: "\f132" / '';
position: absolute;
top: -3px;
right: 100%;
Expand All @@ -308,73 +308,73 @@ body.adding-widget #customize-preview {
}

/* dashicons-smiley */
#available-widgets [class*="easy"] .widget-title:before { content: "\f328"; top: -4px; }
#available-widgets [class*="easy"] .widget-title:before { content: "\f328" / ''; top: -4px; }

/* dashicons-star-filled */
#available-widgets [class*="super"] .widget-title:before,
#available-widgets [class*="like"] .widget-title:before { content: "\f155"; top: -4px; }
#available-widgets [class*="like"] .widget-title:before { content: "\f155" / ''; top: -4px; }

/* dashicons-wordpress */
#available-widgets [class*="meta"] .widget-title:before { content: "\f120"; }
#available-widgets [class*="meta"] .widget-title:before { content: "\f120" / ''; }

/* dashicons-archive */
#available-widgets [class*="archives"] .widget-title:before { content: "\f480"; top: -4px; }
#available-widgets [class*="archives"] .widget-title:before { content: "\f480" / ''; top: -4px; }

/* dashicons-category */
#available-widgets [class*="categor"] .widget-title:before { content: "\f318"; top: -4px; }
#available-widgets [class*="categor"] .widget-title:before { content: "\f318" / ''; top: -4px; }

/* dashicons-admin-comments */
#available-widgets [class*="comment"] .widget-title:before,
#available-widgets [class*="testimonial"] .widget-title:before,
#available-widgets [class*="chat"] .widget-title:before { content: "\f101"; }
#available-widgets [class*="chat"] .widget-title:before { content: "\f101" / ''; }

/* dashicons-admin-post */
#available-widgets [class*="post"] .widget-title:before { content: "\f109"; }
#available-widgets [class*="post"] .widget-title:before { content: "\f109" / ''; }

/* dashicons-admin-page */
#available-widgets [class*="page"] .widget-title:before { content: "\f105"; }
#available-widgets [class*="page"] .widget-title:before { content: "\f105" / ''; }

/* dashicons-text */
#available-widgets [class*="text"] .widget-title:before { content: "\f478"; }
#available-widgets [class*="text"] .widget-title:before { content: "\f478" / ''; }

/* dashicons-admin-links */
#available-widgets [class*="link"] .widget-title:before { content: "\f103"; }
#available-widgets [class*="link"] .widget-title:before { content: "\f103" / ''; }

/* dashicons-search */
#available-widgets [class*="search"] .widget-title:before { content: "\f179"; }
#available-widgets [class*="search"] .widget-title:before { content: "\f179" / ''; }

/* dashicons-menu */
#available-widgets [class*="menu"] .widget-title:before,
#available-widgets [class*="nav"] .widget-title:before { content: "\f333"; }
#available-widgets [class*="nav"] .widget-title:before { content: "\f333" / ''; }

/* dashicons-tagcloud */
#available-widgets [class*="tag"] .widget-title:before { content: "\f479"; }
#available-widgets [class*="tag"] .widget-title:before { content: "\f479" / ''; }

/* dashicons-rss */
#available-widgets [class*="rss"] .widget-title:before { content: "\f303"; top: -6px; }
#available-widgets [class*="rss"] .widget-title:before { content: "\f303" / ''; top: -6px; }

/* dashicons-calendar */
#available-widgets [class*="event"] .widget-title:before,
#available-widgets [class*="calendar"] .widget-title:before { content: "\f145"; top: -4px;}
#available-widgets [class*="calendar"] .widget-title:before { content: "\f145" / ''; top: -4px;}

/* dashicons-format-image */
#available-widgets [class*="image"] .widget-title:before,
#available-widgets [class*="photo"] .widget-title:before,
#available-widgets [class*="slide"] .widget-title:before,
#available-widgets [class*="instagram"] .widget-title:before { content: "\f128"; }
#available-widgets [class*="instagram"] .widget-title:before { content: "\f128" / ''; }

/* dashicons-format-gallery */
#available-widgets [class*="album"] .widget-title:before,
#available-widgets [class*="galler"] .widget-title:before { content: "\f161"; }
#available-widgets [class*="galler"] .widget-title:before { content: "\f161" / ''; }

/* dashicons-format-video */
#available-widgets [class*="video"] .widget-title:before,
#available-widgets [class*="tube"] .widget-title:before { content: "\f126"; }
#available-widgets [class*="tube"] .widget-title:before { content: "\f126" / ''; }

/* dashicons-format-audio */
#available-widgets [class*="music"] .widget-title:before,
#available-widgets [class*="radio"] .widget-title:before,
#available-widgets [class*="audio"] .widget-title:before { content: "\f127"; }
#available-widgets [class*="audio"] .widget-title:before { content: "\f127" / ''; }

/* dashicons-admin-users */
#available-widgets [class*="login"] .widget-title:before,
Expand All @@ -383,55 +383,55 @@ body.adding-widget #customize-preview {
#available-widgets [class*="avatar"] .widget-title:before,
#available-widgets [class*="subscriber"] .widget-title:before,
#available-widgets [class*="profile"] .widget-title:before,
#available-widgets [class*="grofile"] .widget-title:before { content: "\f110"; }
#available-widgets [class*="grofile"] .widget-title:before { content: "\f110" / ''; }

/* dashicons-cart */
#available-widgets [class*="commerce"] .widget-title:before,
#available-widgets [class*="shop"] .widget-title:before,
#available-widgets [class*="cart"] .widget-title:before { content: "\f174"; top: -4px; }
#available-widgets [class*="cart"] .widget-title:before { content: "\f174" / ''; top: -4px; }

/* dashicons-shield */
#available-widgets [class*="secur"] .widget-title:before,
#available-widgets [class*="firewall"] .widget-title:before { content: "\f332"; }
#available-widgets [class*="firewall"] .widget-title:before { content: "\f332" / ''; }

/* dashicons-chart-bar */
#available-widgets [class*="analytic"] .widget-title:before,
#available-widgets [class*="stat"] .widget-title:before,
#available-widgets [class*="poll"] .widget-title:before { content: "\f185"; }
#available-widgets [class*="poll"] .widget-title:before { content: "\f185" / ''; }

/* dashicons-feedback */
#available-widgets [class*="form"] .widget-title:before { content: "\f175"; }
#available-widgets [class*="form"] .widget-title:before { content: "\f175" / ''; }

/* dashicons-email-alt */
#available-widgets [class*="subscribe"] .widget-title:before,
#available-widgets [class*="news"] .widget-title:before,
#available-widgets [class*="contact"] .widget-title:before,
#available-widgets [class*="mail"] .widget-title:before { content: "\f466"; }
#available-widgets [class*="mail"] .widget-title:before { content: "\f466" / ''; }

/* dashicons-share */
#available-widgets [class*="share"] .widget-title:before,
#available-widgets [class*="socia"] .widget-title:before { content: "\f237"; }
#available-widgets [class*="socia"] .widget-title:before { content: "\f237" / ''; }

/* dashicons-translation */
#available-widgets [class*="lang"] .widget-title:before,
#available-widgets [class*="translat"] .widget-title:before { content: "\f326"; }
#available-widgets [class*="translat"] .widget-title:before { content: "\f326" / ''; }

/* dashicons-location-alt */
#available-widgets [class*="locat"] .widget-title:before,
#available-widgets [class*="map"] .widget-title:before { content: "\f231"; }
#available-widgets [class*="map"] .widget-title:before { content: "\f231" / ''; }

/* dashicons-download */
#available-widgets [class*="download"] .widget-title:before { content: "\f316"; }
#available-widgets [class*="download"] .widget-title:before { content: "\f316" / ''; }

/* dashicons-cloud */
#available-widgets [class*="weather"] .widget-title:before { content: "\f176"; top: -4px;}
#available-widgets [class*="weather"] .widget-title:before { content: "\f176" / ''; top: -4px;}

/* dashicons-facebook */
#available-widgets [class*="facebook"] .widget-title:before { content: "\f304"; }
#available-widgets [class*="facebook"] .widget-title:before { content: "\f304" / ''; }

/* dashicons-twitter */
#available-widgets [class*="tweet"] .widget-title:before,
#available-widgets [class*="twitter"] .widget-title:before { content: "\f301"; }
#available-widgets [class*="twitter"] .widget-title:before { content: "\f301" / ''; }

@media screen and (max-height: 700px) and (min-width: 981px) {
/* Compact widget-tops on smaller laptops, but not tablets. See ticket #27112#comment:4 */
Expand Down
Loading
Loading