Skip to content

Conversation

@hannahtinkler
Copy link

@hannahtinkler hannahtinkler commented Sep 4, 2025

Trac ticket: https://core.trac.wordpress.org/ticket/63928#ticket

Proposed changes

  • Adds can_moderate field to the comment endpoint responses, to indicate if the authenticated user can edit the comment
  • Adds post_details field to the comment endpoint responses, containing the post ID, title, type, and REST link
  • Adds i_replied field to the comment endpoint responses, to indicate if the authenticated user replied to the comment

Why are these changes being made?

The WordPress app is currently undergoing a upgrade from the V1.1 Jetpack endpoints to the V2 WordPress JSON endpoints. There are a 3 fields missing from the V2 endpoints that are present in the V1.1 endpoints. The WordPress Mobile team need these to be added before they can upgrade to the V2 comment endpoints.


Testing steps

  1. Leave a comment on a post as the bog admin
  2. Make an request authenticated as the blog admin to the comments endpoint for the blog (example below)
  3. Assert that the new fields are present for all returned comments
  4. Assert that can_moderate is true for the comment you left in step 1
  5. Assert that i_replied is false for the comment you left in step 1
  6. Assert that the data in post_details is correct
  7. Reply to the comment you left in step 1 as the bog admin
  8. Make an request authenticated as the blog admin to the comments endpoint for the blog
  9. Assert that i_replied is true for the comment you left in step 1
  10. Make an unauthenticated request to the comments endpoint for the blog
  11. Assert that can_moderate is false for all comments
  12. Assert that i_replied is false for all comments

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props hannahtinkler.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Hi @hannahtinkler! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@github-actions
Copy link

github-actions bot commented Sep 4, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@hannahtinkler hannahtinkler force-pushed the add-additional-fields-to-wp-v2-comments-endpoint branch 3 times, most recently from 66b6b87 to 7644b90 Compare September 5, 2025 13:46
@hannahtinkler hannahtinkler force-pushed the add-additional-fields-to-wp-v2-comments-endpoint branch from 7644b90 to d314583 Compare September 5, 2025 15:55
@hannahtinkler
Copy link
Author

The app team are revisiting how the app uses the existing fields and will investigate use of targetHints and embeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant