#63167 Configure PHPUnit to fail on risky tests#9762
#63167 Configure PHPUnit to fail on risky tests#9762johnbillion wants to merge 5 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
desrosj
left a comment
desrosj
left a comment
There was a problem hiding this comment.
We should also add failOnRisky="true" to tests/phpunit/mutisite.xml.
The commit that caused a test to be considered risky also affected the multisite runs. There are currently no other risky tests run for multisite installs, so let's add it there for consistency.
| - 'composer.*' | ||
| # This files affect the phpunit tests. Changes could affect the outcome. | ||
| - 'tests/phpunit/**' | ||
| - 'phpunit.xml.dist' |
There was a problem hiding this comment.
Looks like the multisite.xml configuration file is caught by the first condition, but what do you think about explicitly naming it here along phpunit.xml.dist just to make it more clear it's within that folder?
2 participants
In #9746 the PHP 8.3 and 8.4 image was updated. This update caused at least one test to become risky as it no longer performs an assertion, but the risky test itself didn't cause a test failure.
There is no reason to allow risky tests to go unseen. This fixes that.
Trac ticket: https://core.trac.wordpress.org/ticket/63167