-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fix Grunt task responsible for upgrading certificate dependency #9769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Grunt task responsible for upgrading certificate dependency #9769
Conversation
Because an exact version is pinned for `composer/ca-bundle`, the `composer update` command cannot update the dependency to the latest version. The command would not work for an individual dependency anyway due to the fact that there is no `composer.lock` file generated.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
What's the bet way to test this? Manually downgrade |
|
That's right.
|
johnbillion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working nicely
Because an exact version is pinned for
composer/ca-bundle, thecomposer updatecommand cannot update the dependency to the latest version.The command would not work for an individual dependency anyway due to the fact that there is no
composer.lockfile generated.This also updates the workflow that tests the build process to verify that the certificate related files in
src/wp-includes/certificatesaffected by the Grunt tasks are up to date.Trac ticket: Core-63939.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.