HTML API: Refactor wp_replace_in_html_tags().
#9850
Draft
+240
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2025
dmsnell
force-pushed
the
html-api/refactor-wp-replace-in-html-tags
branch
2 times, most recently
from
26885cf to
f2edace
Compare
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
dmsnell
force-pushed
the
html-api/refactor-wp-replace-in-html-tags
branch
8 times, most recently
from
8ab87ff to
24abf90
Compare
dmsnell
force-pushed
the
html-api/refactor-wp-replace-in-html-tags
branch
5 times, most recently
from
609f46a to
4ee95a3
Compare
dmsnell
force-pushed
the
html-api/refactor-wp-replace-in-html-tags
branch
5 times, most recently
from
ff2d2d3 to
5bd7239
Compare
dmsnell
force-pushed
the
html-api/refactor-wp-replace-in-html-tags
branch
4 times, most recently
from
754e60d to
80345e7
Compare
dmsnell
force-pushed
the
html-api/refactor-wp-replace-in-html-tags
branch
3 times, most recently
from
bdfa35e to
51d9e33
Compare
dmsnell
force-pushed
the
html-api/refactor-wp-replace-in-html-tags
branch
from
51d9e33 to
b1c8dca
Compare
dmsnell
force-pushed
the
html-api/refactor-wp-replace-in-html-tags
branch
from
b1c8dca to
72c2904
Compare
Trac ticket: Core-63694 This probably improves the performance in terms of both CPU time and memory compared to the old PCRE-based approach.
Was detecting a non-escaped `<` as the start of an “element” and then replaced a newline in the text as `<!-- wpnl -->` since it thought it was replacing inside a tag. In the end that translated into a raw `\n` again in the end.
dmsnell
force-pushed
the
html-api/refactor-wp-replace-in-html-tags
branch
from
72c2904 to
638e665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-63694
See: #9270, (#9850), #9851