Skip to content

Conversation

@desrosj
Copy link
Member

@desrosj desrosj commented Sep 15, 2025

This fixes the failing WordPress Importer plugin tests by pinning the final version of the plugin with support for PHP < 7.2.

Trac ticket: Core-63983


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@desrosj desrosj self-assigned this Sep 15, 2025
@github-actions
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@desrosj desrosj requested a review from swissspidy September 15, 2025 16:32
@desrosj
Copy link
Member Author

desrosj commented Sep 15, 2025

@swissspidy I've made the version dynamic so that the primary branch continues to be tested on 7.2+. Could you give it another look over for me?

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props desrosj, swissspidy.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
Copy link
Member Author

desrosj commented Sep 15, 2025

Also created #9895 for the 6.5 branch, which is the latest branch with support for PHP < 7.2.

@desrosj desrosj changed the title Pin Importer plugin with old PHP support Pin Importer plugin version with old PHP support - 5.2 Sep 15, 2025
@desrosj
Copy link
Member Author

desrosj commented Sep 15, 2025

Merged in r60762.

@desrosj desrosj closed this Sep 15, 2025
@desrosj desrosj deleted the fix/importer-tests-63983-5.2 branch September 15, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants