-
Notifications
You must be signed in to change notification settings - Fork 372
[Website] Saved Playgrounds overlay redesign #2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adamziel
wants to merge
21
commits into
trunk
Choose a base branch
from
manage-sites-blueprints
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,897
−771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "View all blueprints" button was being hidden on mobile due to CSS rules that hide blueprint preview cards beyond a certain position. Fixed by excluding the last child (the View all button) from the hiding rule. Updated e2e tests to work with the new saved playgrounds overlay instead of the old sidebar. The site list has moved from the sidebar to the overlay, so tests that switch between sites or verify site names now use the overlay. Added helper methods openSavedPlaygroundsOverlay() and closeSavedPlaygroundsOverlay() to the test fixtures.
Always shows a "Temporary Playground" row at the top of the Your Playgrounds section in the overlay. When clicked, it either switches to an existing temporary playground or creates a new one if none exists.
ed92e82 to
cb59f08
Compare
The rename button was only opening the modal without telling it which site to rename. The RenameSiteModal needs siteSlugToRename in state to work - without it, the modal renders nothing.
The saved playgrounds overlay now shows the Temporary Playground row at the top of the list. The test was using .first() to get the renamed site, but that now returns the temporary playground. Changed to look for the specific renamed name instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new "Saved Playgrounds" overlay that replaces the sidebar for site management. The overlay provides a centralized place for:
The site manager panel, file editor etc. are still available like before.
CleanShot.2025-12-05.at.02.56.50.mp4
Follow-up work
Test plan
npx nx e2e playground-website