galaxy: fix selects and more #63
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks ok. Let me know when you want to merge. Btw, do you think it makes sense to give you write/admin rights here? |
Collaborator
Author
I guess when I'm happy with the 2.8 galaxy wrappers over here galaxyproteomics/tools-galaxyp#653 and tests run successful again... I will send you a ping.
If you like. |
Collaborator
Author
|
@jpfeuffer any idea why the travis tests are not running here? |
bernt-matthias
force-pushed
the
topic/fix-selects2
branch
from
af8f72e to
a2178f4
Compare
bernt-matthias
force-pushed
the
topic/fix-selects2
branch
from
a2178f4 to
2b9e676
Compare
Collaborator
Author
|
Any idea why CI tests are not starting here? |
and remove copy paste remnants
bernt-matthias
force-pushed
the
topic/fix-selects2
branch
from
6fa4438 to
ad24fae
Compare
count is now required for planemo lint to pass
Collaborator
Author
|
Hey @jpfeuffer lets get tests running first #64 |
Topic/gha tool linting fixes
auto-merge was automatically disabled
October 30, 2023 13:50
Pull request was converted to draft
and fixup for out type parameter in tests
and use delta_frac fot test outputs
eg `--test-condition "compare=sim_size" "delta_frac=0.05"` which is the default
bernt-matthias
force-pushed
the
topic/fix-selects2
branch
from
ad24fae to
d7bf549
Compare
bernt-matthias
force-pushed
the
topic/fix-selects2
branch
3 times, most recently
from
c94e1d5 to
48ea3a3
Compare
instead of conditional
for Galaxy tool description see OpenMS/OpenMS#6568
and make code a bit more readable (hopefully)
for the Galaxy converter
bernt-matthias
force-pushed
the
topic/fix-selects2
branch
from
48ea3a3 to
de203f4
Compare
bernt-matthias
force-pushed
the
topic/fix-selects2
branch
2 times, most recently
from
36e53d5 to
b3f5f54
Compare
test data generation needs to remove whens and set the select parameter
bernt-matthias
force-pushed
the
topic/fix-selects2
branch
from
b3f5f54 to
6178f56
Compare
- remove XML declaration from output - indent XML
Collaborator
Author
|
@jpfeuffer 767f148 was used to generate the Galaxy tools for 3.1 (which have now been released). |
some OpenMS tools have parameters with the same name (different sections). This creates problems in Galaxy. workaround is to hardcode a unique prefix. Before _ was used which now creates problems with the tool linting (parameters are not supposed to start with _). Hence we now use prefix of the form DEDUP_[0-9]+_DEDUP_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
output-prefixconvert to cwl: output-prefix support #61