feature: Add delegate filter param for account_tx RPC #6126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6126 +/- ##
=========================================
+ Coverage 78.6% 79.1% +0.5%
=========================================
Files 818 839 +21
Lines 68938 71425 +2487
Branches 8240 8346 +106
=========================================
+ Hits 54177 56469 +2292
- Misses 14761 14956 +195
... and 71 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
|
A few suggestions to the new API:
|
kuznetsss
reviewed
Jan 5, 2026
| auto const& filter = options.delegate.value(); | ||
| auto const& contextAccount = options.account; | ||
|
|
||
| if (filter.type == DelegateType::Delegatee) |
Contributor
There was a problem hiding this comment.
I think it would be better to use switch case for enum
Comment on lines
+464
to
+501
| if (params.isMember("delegate")) | ||
| { | ||
| auto const& delegateNode = params["delegate"]; | ||
|
|
||
| if (!delegateNode.isObject() || | ||
| !delegateNode.isMember(jss::delegate_filter)) | ||
| return RPC::invalid_field_error("delegate"); | ||
|
|
||
| DelegateFilter filter; | ||
|
|
||
| if (!delegateNode[jss::delegate_filter].isString()) | ||
| return RPC::invalid_field_error(jss::delegate_filter); | ||
|
|
||
| auto const& delegateFilterStr = | ||
| delegateNode[jss::delegate_filter].asString(); | ||
|
|
||
| if (delegateFilterStr == "delegatee") | ||
| filter.type = DelegateType::Delegatee; | ||
| else if (delegateFilterStr == "delegator") | ||
| filter.type = DelegateType::Delegator; | ||
| else | ||
| return RPC::invalid_field_error(jss::delegate_filter); | ||
|
|
||
| if (delegateNode.isMember(jss::counterparty)) | ||
| { | ||
| if (!delegateNode[jss::counterparty].isString()) | ||
| return RPC::invalid_field_error(jss::counterparty); | ||
|
|
||
| auto const counterparty = parseBase58<AccountID>( | ||
| delegateNode[jss::counterparty].asString()); | ||
| if (!counterparty) | ||
| return rpcError(rpcACT_MALFORMED); | ||
|
|
||
| filter.counterparty = *counterparty; | ||
| } | ||
|
|
||
| args.delegate = filter; | ||
| } |
Contributor
There was a problem hiding this comment.
Maybe all of this could be moved to a static method of DelegateFilter?
std::expected<std::optional<DelegateFilter>, RpcError> create(params);The the usage will be much simpler:
if (auto const filter = DelegateFilter::create(params); filter.has_value()) {
args.filter = *filter;
} else {
return filter.error();
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR adds the ability to filter account_tx results based on transaction delegation. This is useful for scenarios where one account (the delegatee) signs and submits a transaction on behalf of another account (the delegator).
Context of Change
New Request Parameter:
"delegate": {
"delegate_filter": "delegatee" or "delegator",
"counter_party": "account_address"
}
Example: If User A submits a transaction to C on behalf of B:
User B (The account holder) can query with delegate_filter: "delegatee" to find transactions signed by others (like User A).
User A (The signer) can query with delegate_filter: "delegator" to find transactions they signed for others (like User B).
The counter_party field can be used in either case to filter by a specific valid address
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)