Draft
Conversation
Author
|
为啥三个test check过不了。 |
Contributor
|
Author
缺少 |
Contributor
测试前应该先将 |
Author
Windows 环境测试通过,Macos和ubuntu无法测试通过。 |
ghost
reviewed
Mar 20, 2021
app/router/router.go
Outdated
| access sync.RWMutex | ||
| domainStrategy Config_DomainStrategy | ||
| rules []*Rule | ||
| rules map[string]*Rule |
|
感谢您的贡献,有几个需要注意的地方需要说明:
因此,我暂时将此 PR 修改为 work in progress。 |
Author
Map已修改为Slice,取出时采用遍历方式取出需要的 |
Closed
This was
linked to
issues
Mar 22, 2021
Closed
a80df64 to
707efd6
Compare
c73e413 to
a4e80f0
Compare
b11fcf0 to
7e24239
Compare
208f801 to
db934f0
Compare
8e4f881 to
cbade89
Compare
9ebd6ad to
d418401
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
参照handlerService写了一份控制路由的grpc api。
支持使用gRPC 增加 删除 改变
RuleObject,BalancerObject。风格基本与handlerservice一致。原本的
RuleObject没有tag属性,此次修改增加了tag属性。用于控制从配置文件加入的RuleObject,不填tag属性时会采用uuid作为RuleObject的tag。原本RuleObject的tag标签改为TargetTag。Test Case只完成了
RuleObject相关的。BalancerObject由于不会添加Outbound所以未能完成。