Skip to content

Document the usage of PyAwaitable_AsyncWith.#86

Open
AraHaan wants to merge 6 commits intoZeroIntensity:masterfrom
AraHaan:async-with-changes
Open

Document the usage of PyAwaitable_AsyncWith.#86
AraHaan wants to merge 6 commits intoZeroIntensity:masterfrom
AraHaan:async-with-changes

Conversation

@AraHaan
Copy link
Collaborator

@AraHaan AraHaan commented Dec 16, 2025

No description provided.

@AraHaan AraHaan added the docs Improvements or additions to documentation label Dec 16, 2025
@netlify
Copy link

netlify bot commented Dec 16, 2025

Deploy Preview for pyawaitable ready!

Name Link
🔨 Latest commit 8e5fc7b
🔍 Latest deploy log https://app.netlify.com/projects/pyawaitable/deploys/6941a091883a8000082999a1
😎 Deploy Preview https://deploy-preview-86--pyawaitable.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Also included is documentation for using PyAwaitable_AsyncWith as well.

Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
@AraHaan AraHaan changed the title Update PyAwaitable_AsyncWith to returns -1 when aw or ctx are NULL. Update PyAwaitable_AsyncWith to return -1 when aw or ctx are NULL. Dec 16, 2025
@ZeroIntensity
Copy link
Owner

I'm not sure I understand your rationale behind this change. Is it that you want to be able to do something like PyAwaitable_AsyncWith(..., PyObject_CallNoArgs(...), ..., ...). If so, then this change isn't sufficient to do that; the result of the function will be leaked. We can't change that without breaking this API.

Signed-off-by: AraHaan <seandhunt_7@yahoo.com>
@AraHaan AraHaan changed the title Update PyAwaitable_AsyncWith to return -1 when aw or ctx are NULL. Document the using PyAwaitable_AsyncWith. Dec 16, 2025
@AraHaan AraHaan changed the title Document the using PyAwaitable_AsyncWith. Document the usage of PyAwaitable_AsyncWith. Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants