Introduce Timeout object for clock device #862
+35
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Grazfather
reviewed
Jan 16, 2026
mathk
force-pushed
the
clock-device-timeout
branch
3 times, most recently
from
52b4cd9 to
185c0cf
Compare
mattnite
reviewed
Jan 19, 2026
| ttd.elapse_time(2); | ||
| try std.testing.expectEqual(2, td.get_time_since_boot().to_us()); | ||
|
|
||
| try std.testing.expect(!td.is_reached(@enumFromInt(4))); |
Contributor
There was a problem hiding this comment.
Why are these assertions deleted?
Collaborator
Author
There was a problem hiding this comment.
I did remove is_reached from the public interface. There is now test around the Timeout which is the new public interface.
mathk
force-pushed
the
clock-device-timeout
branch
from
185c0cf to
4a92506
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.