-
Notifications
You must be signed in to change notification settings - Fork 124
fix: Add no-arg overload for getUserInput() in RequestContext to avoid #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ehsavoie
wants to merge
1
commit into
a2aproject:main
Choose a base branch
from
ehsavoie:issue_668
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -224,6 +224,24 @@ public List<Task> getRelatedTasks() { | |
| return params != null ? params.tenant() : null; | ||
| } | ||
|
|
||
| /** | ||
| * Extracts all text content from the message and joins with the newline delimiter. | ||
| * <p> | ||
| * This is a convenience method for getting text input from messages that may contain | ||
| * multiple text parts. Non-text parts (images, etc.) are ignored. | ||
| * <p> | ||
| * <b>Examples:</b> | ||
| * <pre>{@code | ||
| * // Join with newlines (common for multi-paragraph input) | ||
| * String text = context.getUserInput("\n"); | ||
| * }</pre> | ||
| * | ||
| * @return all text parts joined with newline, or empty string if no message | ||
| */ | ||
| public String getUserInput() { | ||
| return getUserInput("\n"); | ||
| } | ||
|
|
||
| /** | ||
| * Extracts all text content from the message and joins with the specified delimiter. | ||
| * <p> | ||
|
|
@@ -245,14 +263,15 @@ public List<Task> getRelatedTasks() { | |
| * @param delimiter the string to insert between text parts (null defaults to "\n") | ||
| * @return all text parts joined with delimiter, or empty string if no message | ||
| */ | ||
| public String getUserInput(String delimiter) { | ||
| public String getUserInput(@Nullable String delimiter) { | ||
| if (params == null) { | ||
| return ""; | ||
| } | ||
| String delim = delimiter; | ||
| if (delimiter == null) { | ||
| delimiter = "\n"; | ||
| delim = "\n"; | ||
| } | ||
| return getMessageText(params.message(), delimiter); | ||
| return getMessageText(params.message(), delim); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Small suggestion. How about using a ternary operator here? It might make the code simpler.
|
||
| } | ||
|
|
||
| /** | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Javadoc example for the new
getUserInput()method is incorrect. It shows a call togetUserInput("\n"), which is the method it's meant to simplify. The example should demonstrate the use of the no-argument overload.