Skip to content

Comments

feat: Add getMetadata for RequestContext#676

Closed
flex-myeonghyeon wants to merge 2 commits intoa2aproject:mainfrom
flex-myeonghyeon:add-get-metadata-for-request-context
Closed

feat: Add getMetadata for RequestContext#676
flex-myeonghyeon wants to merge 2 commits intoa2aproject:mainfrom
flex-myeonghyeon:add-get-metadata-for-request-context

Conversation

@flex-myeonghyeon
Copy link
Contributor

@flex-myeonghyeon flex-myeonghyeon commented Feb 21, 2026

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests pass
  • Appropriate READMEs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @flex-myeonghyeon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the capability to access metadata associated with a request within the RequestContext. This enhancement provides a standardized way to retrieve additional context information, improving the flexibility and utility of the request handling process. The change includes the necessary method implementation and corresponding tests to ensure correctness.

Highlights

  • New Feature: Metadata Access: A new getMetadata() method has been added to the RequestContext class, allowing retrieval of request-specific metadata as a Map<String, Object>.
  • Test Coverage: Comprehensive unit tests have been introduced to validate the functionality of the new getMetadata() method, including cases for null metadata and successful retrieval.
Changelog
  • server-common/src/main/java/io/a2a/server/agentexecution/RequestContext.java
    • Imported java.util.Map to support map-based metadata.
    • Added a public method getMetadata() which returns the request metadata as a Map<String, Object> or null.
  • server-common/src/test/java/io/a2a/server/agentexecution/RequestContextTest.java
    • Imported java.util.HashMap for test data creation.
    • Added an assertion to testInitWithoutParams to confirm getMetadata() returns null when no parameters are provided.
    • Introduced testInitWithParamsMetadata to verify that getMetadata() correctly returns the metadata passed during RequestContext initialization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@flex-myeonghyeon flex-myeonghyeon changed the title [Feat] Add getMetadata for RequestContext [feat] Add getMetadata for RequestContext Feb 21, 2026
@flex-myeonghyeon flex-myeonghyeon changed the title [feat] Add getMetadata for RequestContext feat: Add getMetadata for RequestContext Feb 21, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully adds the getMetadata method to the RequestContext class, enabling access to request metadata. The implementation is straightforward and includes relevant unit tests to verify the new functionality. The suggested improvement to return an unmodifiable map for better encapsulation and consistency with existing methods in the class has been retained as it aligns with general best practices and is not contradicted by any specific rules.

Comment on lines 207 to 209
public @Nullable Map<String, Object> getMetadata() {
return params != null ? params.metadata() : null;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain the immutability of the RequestContext and ensure consistency with other methods like getRelatedTasks(), it is best practice to return an unmodifiable view of the metadata map. This prevents external callers from modifying the internal state of the request parameters.

Suggested change
public @Nullable Map<String, Object> getMetadata() {
return params != null ? params.metadata() : null;
}
public @Nullable Map<String, Object> getMetadata() {
return (params != null && params.metadata() != null) ? Collections.unmodifiableMap(params.metadata()) : null;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants