feat: Add getMetadata for RequestContext#676
feat: Add getMetadata for RequestContext#676flex-myeonghyeon wants to merge 2 commits intoa2aproject:mainfrom
Conversation
Summary of ChangesHello @flex-myeonghyeon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the capability to access metadata associated with a request within the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully adds the getMetadata method to the RequestContext class, enabling access to request metadata. The implementation is straightforward and includes relevant unit tests to verify the new functionality. The suggested improvement to return an unmodifiable map for better encapsulation and consistency with existing methods in the class has been retained as it aligns with general best practices and is not contradicted by any specific rules.
| public @Nullable Map<String, Object> getMetadata() { | ||
| return params != null ? params.metadata() : null; | ||
| } |
There was a problem hiding this comment.
To maintain the immutability of the RequestContext and ensure consistency with other methods like getRelatedTasks(), it is best practice to return an unmodifiable view of the metadata map. This prevents external callers from modifying the internal state of the request parameters.
| public @Nullable Map<String, Object> getMetadata() { | |
| return params != null ? params.metadata() : null; | |
| } | |
| public @Nullable Map<String, Object> getMetadata() { | |
| return (params != null && params.metadata() != null) ? Collections.unmodifiableMap(params.metadata()) : null; | |
| } |
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.Fixes #<issue_number_goes_here> 🦕