-
Notifications
You must be signed in to change notification settings - Fork 313
feat: Add agent card as a route in rest adapter #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @rajeshvelicheti, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've implemented changes to the REST adapter to expose the agent card via a new dedicated endpoint. My primary goal was to ensure that the agent card is always accessible through a consistent route, with the logic for determining whether to serve a public or authenticated version of the card now encapsulated within the handler method itself. This simplifies the route registration process and centralizes the card serving logic.
Highlights
- New Agent Card Route: I've added a new GET route, '/v1/card', to the REST adapter. This endpoint will now serve the agent card information.
- Agent Card Handling Logic Refinement: I've refactored the logic for serving the agent card. Previously, the '/v1/card' route was conditionally registered. Now, the route is always registered to handle_get_agent_card, and the decision to serve a public or authenticated extended card is handled within the handle_get_agent_card method itself, based on whether 'self.agent_card.supports_authenticated_extended_card' is true.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds the /v1/card route to the REST adapter and centralizes the logic for serving the agent card. This is a good improvement as it fixes an issue where the agent card route might not have been available if authenticated cards were not supported. I've left one minor comment regarding code style consistency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
BEGIN_COMMIT_OVERRIDE
feat: Add agent card as a route in rest adapter
Release-As: 0.3.1
END_COMMIT_OVERRIDE