-
Notifications
You must be signed in to change notification settings - Fork 313
test: Correctly run tests with the requested Python version #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ll tests run with the stock Python.
… shows the enum name. Adjust the error message to only show the string value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @amauryfa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've addressed an issue where our GitHub Actions workflow for testing with specific Python versions (like 3.13) was incorrectly defaulting to Python 3.10. This pull request updates the CI configuration to correctly set the Python version during the uv installation step and includes necessary code adjustments to ensure our tests are fully compatible across different Python versions, particularly Python 3.13.
Highlights
- CI/CD Workflow Fix: I've updated the GitHub Actions workflow to ensure that tests are executed with the explicitly requested Python version (e.g., Python 3.13) instead of defaulting to an older version like 3.10. This involves correctly configuring the python-version during the uv installation step.
- Python 3.13 Test Compatibility: I've adjusted tests in tests/server/events/test_event_queue.py to account for a change in Python 3.13 where asyncio.QueueShutDown is raised instead of asyncio.QueueEmpty when interacting with a closed asyncio.Queue. This ensures our test suite remains robust across Python versions.
- Error Message Refinement: I've updated error messages in src/a2a/server/request_handlers/default_request_handler.py to correctly display the string value of task states by accessing the .value attribute, providing more informative error messages.
- Test Pattern Broadening: I've refined a pytest.raises match pattern in tests/server/apps/jsonrpc/test_jsonrpc_app.py to be more flexible, accommodating potential minor variations in error messages across Python versions or environments.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses an issue where tests were not running with the specified Python version in the CI. The changes correctly configure the Python version for testing and update the codebase to ensure compatibility across different Python versions, particularly for Python 3.13. The modifications include using explicit .value for enums, making test error message matching more flexible with regex, and handling version-specific asyncio exceptions. My feedback focuses on improving code maintainability in the tests by reducing duplication.
The action "Test with Python 3.13" does not work as expected, all tests are run with Python 3.10.
For exemple, this run shows:
I modified the script to set
python-versionon the "Install uv" step, this is the one that really creates the Python installation.Then I fixed the tests, they should work with all Pythons now.